Bug 1787267
| Summary: | Misleading fail message: deprecation of 'ovirt_host_facts' to be renamed to 'ovirt_host_info' | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [oVirt] ovirt-ansible-collection | Reporter: | Sang Un Ahn <realapyo> | ||||
| Component: | hosted-engine-setup | Assignee: | Evgeny Slutsky <eslutsky> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Nikolai Sednev <nsednev> | ||||
| Severity: | medium | Docs Contact: | |||||
| Priority: | medium | ||||||
| Version: | unspecified | CC: | bugs, didi, eslutsky, sbonazzo, sradco, stirabos | ||||
| Target Milestone: | ovirt-4.4.0 | Keywords: | Regression, Triaged, ZStream | ||||
| Target Release: | 1.1.1 | Flags: | sbonazzo:
ovirt-4.4?
sbonazzo: planning_ack? sbonazzo: devel_ack+ sbonazzo: testing_ack? |
||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | ovirt-ansible-hosted-engine-setup-1.1.1 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1818869 (view as bug list) | Environment: | |||||
| Last Closed: | 2020-05-20 19:59:44 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | Integration | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1818869 | ||||||
| Attachments: |
|
||||||
We are past 4.3.9 final build and the fix missed it. The warning is really annoying but harmless and 4.4.0 is coming. Re-targeting to 4.4.0 for now. I'd like to add: It's good to update the code to get rid of the deprecation warning, but IMO it's even more important to add a proper error message for the most common failure reason so far, at least for 05_add_host.yml - "ERROR: host is not up, please check logs, perhaps also on the engine machine". Does not need to be in current bug (or PR), though. (In reply to Yedidyah Bar David from comment #5) > I'd like to add: It's good to update the code to get rid of the deprecation > warning, but IMO it's even more important to add a proper error message for > the most common failure reason so far, at least for 05_add_host.yml - > "ERROR: host is not up, please check logs, perhaps also on the engine > machine". Does not need to be in current bug (or PR), though. please open a separate BZ for this one. (In reply to Sandro Bonazzola from comment #6) > (In reply to Yedidyah Bar David from comment #5) > > I'd like to add: It's good to update the code to get rid of the deprecation > > warning, but IMO it's even more important to add a proper error message for > > the most common failure reason so far, at least for 05_add_host.yml - > > "ERROR: host is not up, please check logs, perhaps also on the engine > > machine". Does not need to be in current bug (or PR), though. > > please open a separate BZ for this one. Done, bug 1816002. Not seen on latest components: ovirt-hosted-engine-ha-2.4.2-1.el8ev.noarch ovirt-hosted-engine-setup-2.4.4-1.el8ev.noarch rhvm-appliance.x86_64 2:4.4-20200403.0.el8ev This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020. Since the problem described in this bug report should be resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report. |
Created attachment 1649138 [details] Logs of ovirt-hosted-engine-setup (ansible and engine) Description of problem: When hosted engine deployment failed for some reason, the exact cause of the problem does not appear properly. Instead, a misleading fail message (in fact, a warning) regarding the deprecation of 'ovirt_host_facts' which should be renamed to 'ovirt_host_info' prints out. More detailed messages are needed to help users to figure out the root cause of the problem, e.g. "please look the logs in /var/log/ovirt-hosted-engine-setup/engine-logs-XXXX.../ovirt-engine/engine.log". Version-Release number of selected component (if applicable): oVirt-ansible-engine-setup.noarch 1.1.9-1.el7 ovirt-ansible-hosted-engine-setup.noarch 1.0.32-1.el7 ovirt-engine-appliance.x86_64 1.1.5-1.el7 ovirt-host.x86_64 4.3.5-1.el7 ovirt-host-deploy-common.noarch 1.8.4-1.el7 ovirt-hosted-engine-ha.noarch 2.3.6-1.el7 ovirt-hosted-engine-setup.noarch 2.3.12-1.el7 ovirt-release43.noarch 4.3.7-1.el7 How reproducible: In this case, the static IP address for hosted engine VM was not properly applied so the SSH connection to the host was timed out while it tries to deploy a host. The related error messages can be found in /var/log/ovirt-hosted-engine-setup/engine-logs-2020-01-02T01:28:10Z/ovirt-engine/engine.log. However, the ansible log in /var/log/ovirt-hosted-engine-setup/ovirt-hosted-engine-setup-ansible-bootstrap_local_vm-20200102095656-la9gto.log only reports that it is failed because of the use of 'ovirt_host_facts' to be deprecated instead of 'ovirt_host_info'. Steps to Reproduce: 1. 2. 3. Actual results: Failure of hosted engine deployment Expected results: The proper error messages are printed out related to the root cause Additional info: