Bug 1787905

Summary: Manila share does not get into "shrinking_possible_data_loss_error" status when shrinking a share
Product: Red Hat OpenStack Reporter: lkuchlan <lkuchlan>
Component: openstack-manilaAssignee: Tom Barron <tbarron>
Status: CLOSED ERRATA QA Contact: vhariria
Severity: medium Docs Contact: mmurray
Priority: medium    
Version: 13.0 (Queens)CC: astillma, ccopello, gouthamr, tbarron, vimartin
Target Milestone: z13Keywords: Triaged, ZStream
Target Release: 13.0 (Queens)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: openstack-manila-6.3.2-4.el7ost Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-10-28 18:26:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Manila logs none

Comment 1 lkuchlan 2020-01-05 11:41:45 UTC
Created attachment 1649954 [details]
Manila logs

Comment 2 Tom Barron 2020-01-07 17:04:37 UTC
We'll discuss this upstream via https://bugs.launchpad.net/bugs/1858328 but it seems to me the NetApp back end is doing the right thing -- throwing an error and *preventing* data loss so that we shouldn't be throwing an exception indicating  possible data loss, that is, the expectation on the part of the tests is wrong.  Setting the component to python-manilatests while we investigate.

Comment 3 lkuchlan 2020-02-26 09:45:37 UTC
(In reply to Tom Barron from comment #2)
> We'll discuss this upstream via https://bugs.launchpad.net/bugs/1858328 but
> it seems to me the NetApp back end is doing the right thing -- throwing an
> error and *preventing* data loss so that we shouldn't be throwing an
> exception indicating  possible data loss, that is, the expectation on the
> part of the tests is wrong.  Setting the component to python-manilatests
> while we investigate.

What an exception we expect?
According to my understanding, the status of the should remain "available", however,
it's "shrinking_error".
In which case the status of the share is "shrinking_possible_data_loss_error"?

Comment 4 Goutham Pacha Ravi 2020-02-27 18:57:57 UTC
We discussed this bug upstream a little bit during our upstream community meeting [1]. We'll take our findings to the upstream bug [2] - but the short version is that we agree with Liron's finding on this bug. It is a result of a technical debt that we ought to fix, and backport to maintained releases. We have an owner identified and a milestone target (upstream Ussuri release milestone 3). 

[1] http://eavesdrop.openstack.org/meetings/manila/2020/manila.2020-02-27-15.01.log.html#l-72
[2] https://bugs.launchpad.net/bugs/1858328

Comment 7 lkuchlan 2020-10-13 08:57:11 UTC
Tested using:
puppet-manila-12.5.1-3.el7ost.noarch
python2-manila-tests-tempest-1.1.0-1.el7ost.noarch
python2-manilaclient-1.21.2-1.el7ost.noarch

(overcloud) [stack@undercloud-0 ~]$ manila list --all
+--------------------------------------+------------------------------------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+----------------------------------+
| ID                                   | Name                               | Size | Share Proto | Status    | Is Public | Share Type Name | Host                    | Availability Zone | Project ID                       |
+--------------------------------------+------------------------------------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+----------------------------------+
| 6dfa447e-700e-4c29-b147-c92eaedf3de3 | tempest-manila-scenario-2122761758 | 2    | NFS         | available | False     | default         | hostgroup@cephfs#cephfs | nova              | 177fab117bda41229420aeb126afd03d |
+--------------------------------------+------------------------------------+------+-------------+-----------+-----------+-----------------+-------------------------+-------------------+----------------------------------+

(overcloud) [stack@undercloud-0 ~]$ manila shrink 6dfa447e-700e-4c29-b147-c92eaedf3de3 1

(overcloud) [stack@undercloud-0 ~]$ manila list --all
+--------------------------------------+------------------------------------+------+-------------+------------------------------------+-----------+-----------------+-------------------------+-------------------+----------------------------------+
| ID                                   | Name                               | Size | Share Proto | Status                             | Is Public | Share Type Name | Host                    | Availability Zone | Project ID                       |
+--------------------------------------+------------------------------------+------+-------------+------------------------------------+-----------+-----------------+-------------------------+-------------------+----------------------------------+
| 6dfa447e-700e-4c29-b147-c92eaedf3de3 | tempest-manila-scenario-2122761758 | 2    | NFS         | shrinking_possible_data_loss_error | False     | default         | hostgroup@cephfs#cephfs | nova              | 177fab117bda41229420aeb126afd03d |
+--------------------------------------+------------------------------------+------+-------------+------------------------------------+-----------+-----------------+-------------------------+-------------------+----------------------------------+

Comment 13 errata-xmlrpc 2020-10-28 18:26:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 13 bug fix and enhancement advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4387