Bug 1788157
| Summary: | Review Request: perl-String-Trim-More - Various string trimming utilities | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Sandro Mani <manisandro> |
| Component: | Package Review | Assignee: | Petr Pisar <ppisar> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, ppisar |
| Target Milestone: | --- | Flags: | ppisar:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-01-17 18:08:13 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Sandro Mani
2020-01-06 15:00:34 UTC
Spec URL: https://smani.fedorapeople.org/review/perl-String-Trim-More.spec SRPM URL: https://smani.fedorapeople.org/review/perl-String-Trim-More-0.03-2.fc32.src.rpm * Tue Jan 07 2020 Sandro Mani <manisandro> - 0.03-2 - Fix / constrain BRs - Pass NO_PACKLIST=1 to Makefile.PL - Run fixperms on buildroot URL and Source0 addresses are usable. Ok. Source0 archive (SHA-256: 739cfbd73e0a92897c6f31f0ad8d72a56302f8805e9707d4edca5e5086c14e7f) is original. Ok. Summary verified from lib/String/Trim/More.pm. Ok. Description verified from lib/String/Trim/More.pm. Ok. License verified from LICENSE, lib/String/Trim/More.pm, and Makefile.PL. FIX: Change the license tag to "GPL+ or Artistic". "Perl" is not a valid license identifier <https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses>. No XS code, noarch BuildArch is Ok. Test::Pod::Coverage, Test::Pod, and Pod::Coverage::TrustPod are not used. Ok. All tests pass. Ok. $ rpmlint perl-String-Trim-More.spec ../SRPMS/perl-String-Trim-More-0.03-2.fc32.src.rpm ../RPMS/noarch/perl-String-Trim-More-0.03-2.fc32.noarch.rpm sh: /usr/bin/python2: No such file or directory perl-String-Trim-More.src: W: invalid-license Perl perl-String-Trim-More.noarch: W: invalid-license Perl 2 packages and 1 specfiles checked; 0 errors, 2 warnings. FIX: Correct the license tag. $ rpm -q -lv -p ../RPMS/noarch/perl-String-Trim-More-0.03-2.fc32.noarch.rpm drwxr-xr-x 2 root root 0 Jan 8 15:31 /usr/share/doc/perl-String-Trim-More -rw-r--r-- 1 root root 294 Jan 27 2017 /usr/share/doc/perl-String-Trim-More/Changes -rw-r--r-- 1 root root 1551 Jan 27 2017 /usr/share/doc/perl-String-Trim-More/README drwxr-xr-x 2 root root 0 Jan 8 15:31 /usr/share/licenses/perl-String-Trim-More -rw-r--r-- 1 root root 18367 Jan 27 2017 /usr/share/licenses/perl-String-Trim-More/LICENSE -rw-r--r-- 1 root root 2279 Jan 8 15:31 /usr/share/man/man3/String::Trim::More.3pm.gz drwxr-xr-x 2 root root 0 Jan 8 15:31 /usr/share/perl5/vendor_perl/String drwxr-xr-x 2 root root 0 Jan 8 15:31 /usr/share/perl5/vendor_perl/String/Trim -rw-r--r-- 1 root root 4015 Jan 27 2017 /usr/share/perl5/vendor_perl/String/Trim/More.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-String-Trim-More-0.03-2.fc32.noarch.rpm | sort -f | uniq -c 1 perl(:MODULE_COMPAT_5.30.1)- 1 perl(:VERSION) >= 5.10.1 1 perl(Exporter) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsZstd) <= 5.4.18-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-String-Trim-More-0.03-2.fc32.noarch.rpm | sort -f | uniq -c 1 perl(String::Trim::More) = 0.03 1 perl-String-Trim-More = 0.03-2.fc32 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-String-Trim-More-0.03-2.fc32.noarch.rpm Binary dependencies are resolvable. Ok. The package builds in F32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=40282066). Ok. Otherwise the package is in line with Fedora and Perl packaging guilelines. Please correct the license tag and provide a new spec file. Resolution: Package NOT approved. Spec URL: https://smani.fedorapeople.org/review/perl-String-Trim-More.spec SRPM URL: https://smani.fedorapeople.org/review/perl-String-Trim-More-0.03-3.fc32.src.rpm %changelog * Wed Jan 08 2020 Sandro Mani <manisandro> - 0.03-3 - Fix license tag > FIX: Change the license tag to "GPL+ or Artistic". "Perl" is not a valid license identifier <https://fedoraproject.org/wiki/Licensing:Main#Good_Licenses>.
Ok.
$ rpmlint perl-String-Trim-More.spec ../SRPMS/perl-String-Trim-More-0.03-3.fc32.src.rpm ../RPMS/noarch/perl-String-Trim-More-0.03-3.fc32.noarch.rpm
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
Resolution: Package APPROVED.
Thanks! (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-String-Trim-More |