Bug 1788178

Spec URL: https://smani.fedorapeople.org/review/perl-Test-Regexp-Pattern.spec
SRPM URL: https://smani.fedorapeople.org/review/perl-Test-Regexp-Pattern-0.006-2.fc32.src.rpm

%changelog
* Tue Jan 07 2020 Sandro Mani <manisandro> - 0.006-2
- Fix / constrain BRs
- Pass NO_PACKLIST=1 to Makefile.PL
- Run fixperms on buildroot

 - Use

%build
perl Makefile.PL INSTALLDIRS=vendor NO_PACKLIST=1 NO_PERLLOCAL=1
%{make_build}

%install
%{make_install}

Spec URL: https://smani.fedorapeople.org/review/perl-Test-Regexp-Pattern.spec
SRPM URL: https://smani.fedorapeople.org/review/perl-Test-Regexp-Pattern-0.006-3.fc32.src.rpm

%changelog
* Wed Jan 08 2020 Sandro Mani <manisandro> - 0.006-3
- Use NO_PERLLOCAL=1 and %%make_install

URL and Source0 addresses are usable. Ok.
Source0 archive (SHA-256: 49434269e3b5d52c1be476fbf6dcff7025531445fcf7a84aef79a20c1307dd8d) is original. Ok.
Summary verified from lib/Test/Regexp/Pattern.pm. Ok.
Description verified from lib/Test/Regexp/Pattern.pm. Ok.
License verified from README, lib/Test/Regexp/Pattern.pm, LICENSE, and Makefile.PL. Ok.
No XS code, noarch BuildArch is Ok.

TODO: Constrain 'perl(Getopt::Long)' with '>= 2.50' (META.json:36).
TODO: Constrain 'perl(Hash::DefHash)' with '>= 0.06' (META.json:37).
TODO: Constrain 'perl(Regexp::Pattern)' with ' >= 0.2.7' (META.json:38).
FIX: Build-require 'perl(blib)' for tests (t/00-compile.t:22).

Pod::Coverage::TrustPod, Test::Pod::Coverage, Test::Perl::Critic, and Test::Pod are not used. Ok.

All tests pass. Ok.

$ rpmlint perl-Test-Regexp-Pattern.spec ../SRPMS/perl-Test-Regexp-Pattern-0.006-3.fc32.src.rpm ../RPMS/noarch/perl-Test-Regexp-Pattern-0.006-3.fc32.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-Test-Regexp-Pattern-0.006-3.fc32.noarch.rpm 
-rwxr-xr-x    1 root     root                     2029 Jan 13 11:07 /usr/bin/test-regexp-pattern
drwxr-xr-x    2 root     root                        0 Jan 13 11:07 /usr/share/doc/perl-Test-Regexp-Pattern
-rw-r--r--    1 root     root                     1046 Jan  4 01:14 /usr/share/doc/perl-Test-Regexp-Pattern/Changes
-rw-r--r--    1 root     root                     2792 Jan  4 01:14 /usr/share/doc/perl-Test-Regexp-Pattern/README
drwxr-xr-x    2 root     root                        0 Jan 13 11:07 /usr/share/licenses/perl-Test-Regexp-Pattern
-rw-r--r--    1 root     root                    18385 Jan  4 01:14 /usr/share/licenses/perl-Test-Regexp-Pattern/LICENSE
-rw-r--r--    1 root     root                     1836 Jan 13 11:07 /usr/share/man/man1/test-regexp-pattern.1.gz
-rw-r--r--    1 root     root                     2417 Jan 13 11:07 /usr/share/man/man3/Test::Regexp::Pattern.3pm.gz
drwxr-xr-x    2 root     root                        0 Jan 13 11:07 /usr/share/perl5/vendor_perl/Test
drwxr-xr-x    2 root     root                        0 Jan 13 11:07 /usr/share/perl5/vendor_perl/Test/Regexp
-rw-r--r--    1 root     root                    11192 Jan  4 01:14 /usr/share/perl5/vendor_perl/Test/Regexp/Pattern.pm
File layout and permissions is Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-Test-Regexp-Pattern-0.006-3.fc32.noarch.rpm | sort -f | uniq -c
      1 /usr/bin/perl
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(:VERSION) >= 5.10.0
      1 perl(:VERSION) >= 5.10.1
      1 perl(File::Spec)
      1 perl(Getopt::Long)
      1 perl(Hash::DefHash)
      1 perl(Regexp::Pattern)
      1 perl(strict)
      1 perl(Test::Builder)
      1 perl(Test::More)
      1 perl(Test::Regexp::Pattern)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
TODO: Constrain 'perl(Getopt::Long)' with '>= 2.50' (META.json:36).
TODO: Constrain 'perl(Hash::DefHash)' with '>= 0.06' (META.json:37).
TODO: Constrain 'perl(Regexp::Pattern)' with ' >= 0.2.7' (META.json:38).

$ rpm -q --provides -p ../RPMS/noarch/perl-Test-Regexp-Pattern-0.006-3.fc32.noarch.rpm | sort -f | uniq -c
      1 perl(Test::Regexp::Pattern) = 0.006
      1 perl-Test-Regexp-Pattern = 0.006-3.fc32
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-Test-Regexp-Pattern-0.006-3.fc32.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F32 (https://koji.fedoraproject.org/koji/taskinfo?taskID=40469562). Ok.

Otherwise the package is in line with Fedora and Perl packaging guidelines.

Please correct the 'FIX' item and consider fixing the 'TODO' items before building this package.
Resolution: Package APPROVED.

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Test-Regexp-Pattern

Thanks for all the reviews!