Bug 1788546

Summary:	Check return value of g_mkdir_with_parents() (Repo.cpp:1392)
Product:	Red Hat Enterprise Linux 8	Reporter:	Jaroslav Rohel <jrohel>
Component:	libdnf	Assignee:	amatej
Status:	CLOSED ERRATA	QA Contact:	Eva Mrakova <emrakova>
Severity:	unspecified	Docs Contact:
Priority:	medium
Version:	8.2	CC:	amatej
Target Milestone:	rc	Keywords:	Triaged
Target Release:	8.0	Flags:	pm-rhel: mirror+
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	libdnf-0.47.0-1.el8	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-11-04 01:52:25 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jaroslav Rohel 2020-01-07 13:33:23 UTC

Description of problem:
There is missing check of return value of g_mkdir_with_parents(). Errors during creating directory is silently ignored and program can crash later.
libdnf-0.39.1/libdnf/repo/Repo.cpp:1392: check_return: Calling "g_mkdir_with_parents" without checking return value

Version-Release number of selected component (if applicable):
libdnf-0.39.1-2.el8

Expected results:
At least error message in logger can help in case of problems.

Comment 2 amatej 2020-01-10 13:05:05 UTC

Created PR: https://github.com/rpm-software-management/libdnf/pull/878

Comment 3 amatej 2020-01-10 13:06:44 UTC

Sorry, the Internal Target Release was moved by a mistake.

Comment 10 errata-xmlrpc 2020-11-04 01:52:25 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (yum bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:4510