Bug 1788703

Summary:	python-webob fails to build with Python 3.9
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-webob	Assignee:	Fedora Infrastructure SIG <infra-sig>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	cstratak, infra-sig, karlthered, lewk, mhroncok, mrunge, rbean, ricky
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-10 18:40:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1785415

Description Miro Hrončok 2020-01-07 20:58:37 UTC

python-webob fails to build with Python 3.9.0a2:

E           AttributeError: 'Thread' object has no attribute 'isAlive'


Indeed, isAlive was deprecated since 3.2 and removed in 3.9. Use is_alive instead.

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01140700-python-webob/

For all our attempts to build python-webob with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-webob/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33, but the initial bootstrapping has already started.
A build failure this early in the bootstrap sequence blocks us very much.

Comment 1 Charalampos Stratakis 2020-01-14 01:38:22 UTC

Patch for fixing it:

diff --git a/tests/conftest.py b/tests/conftest.py
index ec47c86..174aebf 100644
--- a/tests/conftest.py
+++ b/tests/conftest.py
@@ -60,7 +60,7 @@ def serve():
             log.debug("shutting server down")
             server.shutdown()
             worker.join(1)
-            if worker.isAlive():
+            if worker.is_alive():
                 log.warning('worker is hanged')
             else:
                 log.debug("server stopped")

Comment 2 Charalampos Stratakis 2020-01-14 02:30:14 UTC

https://src.fedoraproject.org/rpms/python-webob/pull-request/5

Comment 3 Miro Hrončok 2020-02-10 18:40:29 UTC

The PR is already merged and the package builds.