Bug 178901
Summary: | Review Request: gtksourceview-sharp | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul F. Johnson <paul> | ||||
Component: | Package Review | Assignee: | John Mahowald <jpmahowald> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Package Reviews List <fedora-package-review> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | lyz27 | ||||
Target Milestone: | --- | ||||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2006-07-23 13:38:56 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779, 178904 | ||||||
Attachments: |
|
Description
Paul F. Johnson
2006-01-25 11:09:39 UTC
/usr/bin/mcs /unsafe /target:library /pkg:gnome-sharp-2.0 \ generated/*.cs ./GtkSourceView.cs AssemblyInfo.cs -out:gtksourceview-sharp.dll error CS2001: Source file `generated/*.cs' could not be found Compilation failed: 1 error(s), 0 warnings make[1]: *** [gtksourceview-sharp.dll] Error 1 Which version of gtksourceview and gtksourceview-devel have you got installed? And more over, which versions of gtksharp2 and mono-core This problem may be related to #179958 gtksourceview-1.5.7-1 gtksourceview-devel-1.5.7-1 mono-core-1.1.13.2-1 gtksharp2 not installed Haven't updated to latest Rawhide yet (still on the Feb 03 version) but probably will today. It looks like mcs is still borked. I thought that it was down to a kernel problem with lookups for files, but it's not. Hopefully, today's rebuild fixes these problems. It could just be a gcc problem when mono/mcs was built. #1 - the problem is that when it begins to compile, mcs looks for /usr/lib/pkgconfig/../../share/gapi-2.0/gnome-api.xml and doesn't find it. I don't understand why that should be the case as it does exist! Claiming for review. Updated spec Spec Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec Only change is that I'd forgotten to include the docs! #7 if gtk-sharp2-gapi is installed that error disappears (missing dep?). Nope. It was down to the version of mono I was compiling with was bawked. It seems to build happily, though I am going to do some more tests tonight. Updated spec Spec Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec Added additional buildreq (gtk-sharp2-gapi) and a couple of requires. Builds fine on an x86_64 and i386 box. Spec Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp-2.0-3.src.rpm Additional buildreq Spec Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp-2.0-4.src.rpm libdir now set to /usr/lib irrespective of hardware built on spec file fixes Not building on x86_64, missing some assembly: /usr/bin/gapi2-fixup: line 3: which: command not found cannot open assembly ./../lib/gtk-sharp-2.0/gapi-fixup.exe make[1]: *** [gtksourceview-api.xml] Error 2 There are all sorts of problems with Mono, /usr/lib and /usr/lib64. Building under x86_64 is broken because of another bug in the glibc-kernheaders as well (reported, but I've not seen a fix for it). You'll probably find gapi-fixup in /usr/lib64/gtk-sharp-2.0 Spec Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp-2.0-6.src.rpm Quite a lot of fixes from the 0-4 release. I am still having the same x86_64 problems as before, but I have the i386 version running here and at work (work is x86_64) without a problem. This version has both boo and java support built in. Oh poo! Just realised that boo and java support are for monodevelop and not gtksourceview-sharp. I bad ;-p Created attachment 128745 [details]
Mock Build Failure Log
gtksourceview-sharp currently fails in Mock. I've attached the build log, and
if I've got some extra free time later today, I'll look to see what's causing
the problem.
/usr/bin/gapi2-fixup: line 3: which: command not found Build groups changed recently, I believe. It works for me with "config_opts['buildgroup'] = 'build-minimal build-base build'" in the mock config. Well, it does but once I force %_libdir to point to /usr/lib on x86_64. http://fedorared.org/~john/review/gtksourceview-sharp-2.0-7.src.rpm Spec Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec Changes: Fix for x86-64 Now has a devel packages SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp-2.0-8.src.rpm Spec Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp.spec SRPM Name or Url: http://www.smmp.salford.ac.uk/packages/gtksourceview-sharp-2.0-9.src.rpm Changed do the libdir bits are explicit rather than just make everything mine Now please, someone, review it and let's get going on it! Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec SRPM Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-9.src.rpm Change of URL Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec SRPM Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-10.src.rpm Fix for devel file Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec SRPM Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-11.src.rpm - Added BR pkgconfig - Now BuildArch: noarch - altered configure to target something - removed libdir hack For this to compile on a machine that has /usr/lib64 set as _libdir you need to add: %define _libdir %{_exec_prefix}/lib I know. The problem is that things now need to comply with the mono packaging guidelines which I'm having all hells job with trying to get things to work on all platforms with. If you're after the actual packages, http://www.all-the-johnsons.co.uk/mono/rpms.html have the lot as binaries and I know they're fairly happy as well! Patching configure.in and Makefile.am to use %(libdir) works with lib64. http://fedorared.org/~john/review/gtksourceview-sharp-2.0-12.src.rpm Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec SRPM Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-12.src.rpm Very minor change to John's version... That patch to autoconf and automake should go upstream if %(libdir) is the accepted place to drop this. - rpmlint checks return: W: gtksourceview-sharp strange-permission gtksourceview-sharp-libdir.patch 0666 W: gtksourceview-sharp strange-permission gtksourceview-sharp.spec 0666 Ignorable, I'm not scared of 666. W: gtksourceview-sharp incoherent-version-in-changelog 2.0-0.10-12 2.0-12.fc6 Confusion due to the 2.0-0.10 naming in the tarball. Should be fine as long as the release is always bumped if that extra version number is updated, to say 2.0-0.11. E: gtksourceview-sharp no-binary E: gtksourceview-sharp only-non-binary-in-usr-lib Expected for mono. W: gtksourceview-sharp-devel no-documentation Fine. - package meets naming guidelines Just watch out for that version. - package meets packaging guidelines BLOCKER - license is wrong, is LGPL. - spec file legible, in am. english - source matches upstream - package compiles on devel (x86_64) - no missing BR - no unnecessary BR (hopefully autoconf and automake will go away sometime) - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file - devel package ok - no .la files - post/postun ldconfig ok - devel requires base package n-v-r For mono specific stuff the build does call gacutil like the guidelines say. Spec Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp.spec SRPM Name or Url: http://www.knox.net.nz/~nodoid/gtksourceview-sharp-2.0-13.src.rpm Fixes licence OK as per comment 31. APPROVED |