Bug 178932
| Summary: | Review Request: AutoScan - A utility for network exploration | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | thierry <thierry> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Package Reviews List <fedora-package-review> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | imlinux, matthias, panemade, somlo, ToddAndMargo |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2006-08-30 06:09:50 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
thierry
2006-01-25 16:13:09 UTC
You should probably include a direct url for the spec file in addition to the
src.rpm.
You're mixing $RPM_BUILD_ROOT and %{buildroot}. Either is fine, but pick one and
be consistent.
You should probably not install doc/AutoScan/* into %{buildroot} during %install,
but rather just mention it using '%doc Data/doc/Autoscan' in the %files section.
Zooming out to the bigger picture, you probably want separate subpackages for
AutoScan_Agent (at least if it's supposed to run independently of, and
comunicate with, the main system).
you should also add a %changelog section at the end, and document revisions to
your .spec file in there.
There's probably more, but this should get you started...
Spec Name or Url: http://autoscan.free.fr/Fedora/AutoScan.spec -Don't use %define name and %define version. Just define them under Name: and Version: -Provide a working full URL for the Source: file -Increment the revision number every time you submit a change (even to bugzilla) Spec Name or Url: http://autoscan.free.fr/Fedora/AutoScan.spec SRPM Name or Url: http://autoscan.free.fr/Fedora/AutoScan-0.99-0.Fedora.src.rpm This package is going to need a lot of work to get into shape! First think, I'll take the ownership of libzvt as it's been removed from Extras in FC5 because of the lack of a maintainer. Next, as the upstream author, could you comment on the file structure in the sources and the build steps required? Why not simply provide the tarball with the sources in the root, the typical autotools stuff in place, with a configure script already generated? Actually, libzvt seems pretty much dead, and libzvt.so.2 is included in gnome-libs, but gnome-libs-devel doesn't have libzvt/libzvt.h, so this seems to be a problem. Next, as the upstream author, there are many things that could use fixing at a first glance : the autogen.sh step doesn't properly check for libao, libvorbis nor samba libs/headers, and the following make fails miserably. I would really recommend you clean up the autotools/configure stuff you ship. rpmlint gives me following output
W: AutoScan summary-ended-with-dot Utility for network exploration (Samba,Nessus
client).
E: AutoScan description-line-too-long AutoScan is an application designed to
explore and to manage your network. Entire subnets can be scanned simultaneously
without human intervention. It features OS detection, automatic network
discovery, a port scanner, a Samba share browser, and the ability to save the
network state.
W: AutoScan non-standard-group Networking/Other
W: AutoScan invalid-license GNU General Public License (GPL)
W: AutoScan non-coherent-filename AutoScan-0.99-0.Fedora.src.rpm
W: AutoScan strange-permission AutoScan.spec 0744
E: AutoScan hardcoded-library-path in %{buildroot}/usr/lib/menu/
I will close this bug in one week if there is no response from the package submitter. |