Bug 1789479

Summary: [v2v] [RFE] UI changes to support UCI
Product: Red Hat CloudForms Management Engine Reporter: Mike Turley <mturley>
Component: V2VAssignee: Fabien Dupont <fdupont>
Status: CLOSED WONTFIX QA Contact: Md Nadeem <mnadeem>
Severity: high Docs Contact: Red Hat CloudForms Documentation <cloudforms-docs>
Priority: unspecified    
Version: 5.11.0CC: bthurber, dmetzger, fdupont, mfeifer, mnadeem
Target Milestone: GAKeywords: TestOnly, ZStream
Target Release: 5.12.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
: 1805911 (view as bug list) Environment:
Last Closed: 2020-05-13 17:01:20 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: V2V Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1805911    

Description Mike Turley 2020-01-09 16:35:55 UTC
JIRA: https://issues.redhat.com/browse/MIGENG-316

Users will select from a list of VMs rather than a list of hosts when configuring conversion hosts.

BZ for backport to ivanchuk.

Comment 3 Mike Turley 2020-01-13 19:22:52 UTC
In addition to selecting from VMs rather than hosts when configuring a RHV conversion host, we also need to make the following UI changes to support UCI:

* disable CPU throttling
* Handle renaming options[:virtv2v_disks] to options[:disks]
* Handle renaming options[:network_mappings] to options[:nics]

Fabien, at some point can you help me grab a database dump with these renamed field values so I can test the UI changes? Also, when the backend updates go through will old migrations have their field names changed in a DB migration, or does the UI need to be backwards-compatible with the old names?

Comment 4 Mike Turley 2020-01-14 22:02:06 UTC
One additional change we'll need here:

* In the conversion host configuration wizard, we should ask if SSL is enabled and for the CA cert also for RHV, not only for OpenStack.

I'll need to figure out the field names and the API request property name to use here (currently the toggle is called "Verify TLS Certificates for OpenStack", the certificate field is called "OpenStack Trusted CA Certificates" and the API property is `openstack_tls_ca_certs`).

Comment 5 Fabien Dupont 2020-01-15 09:14:43 UTC
I agree that the fields should be "Verify TLS Certificates" and "Trusted CA Certificates".
For the API request, we can change the variable name to make it more generic, like "tls_ca_cert". It's pretty easy and I don't see why the change would be rejected.

Comment 6 Mike Turley 2020-01-29 23:31:52 UTC
The remaining UI changes for this are in https://github.com/ManageIQ/manageiq-v2v/pull/1099, which is WIP for now while we fix a bug blocking it.

The PR changes the variable name from `openstack_tls_ca_certs` to `tls_ca_certs`. We'll need to make sure we make equivalent changes in the backend, I see this name in several places: https://github.com/search?q=org%3AManageIQ+openstack_tls_ca_certs&type=Code

Comment 7 Fabien Dupont 2020-01-31 10:16:27 UTC
Renaming 'openstack_tls_ca_cert' in manageiq: https://github.com/ManageIQ/manageiq/pull/19787
Renaming 'openstack_tls_ca_cert' in manageiq-api: https://github.com/ManageIQ/manageiq-api/pull/732

Comment 8 Mike Turley 2020-02-10 17:42:39 UTC
https://github.com/ManageIQ/manageiq-v2v/pull/1099 is now merged. The UI should be all ready for UCI now.

Comment 9 Mike Turley 2020-02-19 18:03:45 UTC
Talking to Fabien, we realized we had one more requirement here: The UI should no longer ask for a username when configuring a conversion host, it should always be passed as "cloud-user" under the hood. PR coming shortly.

Comment 12 Fabien Dupont 2020-05-13 17:01:20 UTC
Warm migration and UCI will finally not be implemented in CloudForms.
Closing as WONTFIX.