Bug 1790238
| Summary: | gnome-shell search provider does not work | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Christian Stadelmann <fedora> | ||||||||
| Component: | firefox | Assignee: | Martin Stransky <stransky> | ||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | 32 | CC: | 0xalen+redhat, anto.trande, elxreno, gecko-bugs-nobody, jhorak, john.j5live, kengert, pjasicek, rhughes, rstrode, sandmann, stransky | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2020-06-28 08:32:11 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Christian Stadelmann
2020-01-12 21:25:23 UTC
The gnome-shell searcher is active only when Firefox is running. Can you inspect your DBus interface that Firefox search provider is actually here? Install D-Feet dbus inspection tool (dnf install dfeet), switch to session bus and check if org.mozilla.Firefox.SearchProvider is there. Thanks. (In reply to Martin Stransky from comment #1) > The gnome-shell searcher is active only when Firefox is running. Can you > inspect your DBus interface that Firefox search provider is actually here? > Install D-Feet dbus inspection tool (dnf install dfeet), switch to session > bus and check if org.mozilla.Firefox.SearchProvider is there. > Thanks. Dear Martin, thanks for your quick response! Yes, that happens when firefox is running. I see org.mozilla.Firefox.SearchProvider in the d-feet session bus list. Is there anything else you need to know about it? There is also another dbus element on my session bus, `org.mozilla.firefox.bWFpg__`. It has the same two object paths as org.mozilla.Firefox.SearchProvider: `/org/mozilla/Firefox/SearchProvider` and `/org/mozilla/firefox/Remote` PS: The tool is "d-feet" and thus `dnf install d-feet`. (forgot to clear the needinfo flags) I see, Thanks. In this case we may need Bustle. Please install by "dnf install bustle" and then run, start recording dbus session and try to search something. Bustle records dbus traffic and provides complete log. Look for Firefox search provider and how the responses are handled. Also please attach the bustle log here. Thanks. Created attachment 1652269 [details]
PDF exported from bustler
I could get some data from bustler and it looks like it firefox itself works, only the shell does not show results. I searched just for the letter "g".
The first method call has this metadata:
Type: Method call
Sender: :1.8
Destination: :1.240
Path: /org/mozilla/Firefox/SearchProvider
Member: org.gnome.Shell.SearchProvider2.GetInitialResultSet
Arguments: @as ["g"]
The first method return has this metadata:
Type: Method return
Sender: :1.240
Destination: :1.8
Path: /org/mozilla/Firefox/SearchProvider
Member: org.gnome.Shell.SearchProvider2.GetInitialResultSet
Arguments: @as ["00:URL_REDACTED", "01:URL_REDACTED", "02:URL_REDACTED", "03:URL_REDACTED", "04:URL_REDACTED", "05:URL_REDACTED", "06:URL_REDACTED", "07:URL_REDACTED", "08:URL_REDACTED", "special:search:g"]
The second method call has this metadata:
Type: Method call
Sender: :1.8
Destination: :1.240
Path: /org/mozilla/Firefox/SearchProvider
Member: org.gnome.Shell.SearchProvider2.GetResultMetas
Arguments: @as ["00:URL_REDACTED", "01:URL_REDACTED", "02:URL_REDACTED", "03:URL_REDACTED", "04:URL_REDACTED", "special:search:g"]
The second method return has this metadata:
Type: Method return
Sender: :1.240
Destination: :1.8
Path: /org/mozilla/Firefox/SearchProvider
Member: org.gnome.Shell.SearchProvider2.GetResultMetas
But now the "Arguments" is a gigantic answer which may be too large for gnome-shell to parse.
Created attachment 1652271 [details]
pcap file from a *different* capture
Now I tried again with just a single copy-pasted string, "deadbeef". Interestingly, Firefox did not even return the "special:search:deadbeef" entry in its answer to org.gnome.Shell.SearchProvider2.GetInitialResultSet. This looks wrong to me.
Created attachment 1652273 [details] pcap file from a *different* capture with "Deadbeef" as bookmark in firefox Now, I bookmarked the Deadbeef wikipedia page (https://en.wikipedia.org/wiki/Deadbeef) and repeated the previous steps again. This time, Firefox responds as expected to both GetInitialResultSet and GetResultMetas, although I have not checked the format of the GetResultMetas answer. Anyway, gnome-shell still displays no results. In all three cases I disabled all search providers but Firefox. I had only a single firefox instance running. (In reply to Christian Stadelmann from comment #5) > The second method call has this metadata: > Type: Method call > Sender: :1.8 > Destination: :1.240 > Path: /org/mozilla/Firefox/SearchProvider > Member: org.gnome.Shell.SearchProvider2.GetResultMetas > Arguments: @as ["00:URL_REDACTED", "01:URL_REDACTED", "02:URL_REDACTED", > "03:URL_REDACTED", "04:URL_REDACTED", "special:search:g"] > > The second method return has this metadata: > Type: Method return > Sender: :1.240 > Destination: :1.8 > Path: /org/mozilla/Firefox/SearchProvider > Member: org.gnome.Shell.SearchProvider2.GetResultMetas > But now the "Arguments" is a gigantic answer which may be too large for > gnome-shell to parse. GetResultMetas and a reply to it it's a key part of the search provider. I'd need the "Arguments" from GetResultMetas which are send from Firefox to gnome-shell. Can you for instance copy it to a text file, zip it and attach here? Thanks. btw. only history is searched right now, bookmarks are ignored. (In reply to Martin Stransky from comment #9) > […] > GetResultMetas and a reply to it it's a key part of the search provider. I'd > need the "Arguments" from GetResultMetas which are send from Firefox to > gnome-shell. Can you for instance copy it to a text file, zip it and attach > here? > […] I'd rather not attach it here as it contains some private information. Is it ok if I send it to you via E-Mail? Anyway, as the other two retries (see comment #6 and comment #7) also don't work in gnome-shell, I think you already do have a minimal working case. Gnome-shell gets data from Firefox but does not display anything, so I guess the shell needs debugging. (In reply to Martin Stransky from comment #10) > btw. only history is searched right now, bookmarks are ignored. In my case that does not matter because as you can see in the pcap file in comment #7, even the simplest case, a single url in firefox, firefox does send data to gnome-shell, but gnome-shell does not display anything. In this case the website was both bookmarked and visited. (In reply to Christian Stadelmann from comment #11) > (In reply to Martin Stransky from comment #9) > > […] > > GetResultMetas and a reply to it it's a key part of the search provider. I'd > > need the "Arguments" from GetResultMetas which are send from Firefox to > > gnome-shell. Can you for instance copy it to a text file, zip it and attach > > here? > > […] > > I'd rather not attach it here as it contains some private information. Is it > ok if I send it to you via E-Mail? Yes, that's fine, thanks. > Anyway, as the other two retries (see comment #6 and comment #7) also don't > work in gnome-shell, I think you already do have a minimal working case. > Gnome-shell gets data from Firefox but does not display anything, so I guess > the shell needs debugging. > > (In reply to Martin Stransky from comment #10) > > btw. only history is searched right now, bookmarks are ignored. > > In my case that does not matter because as you can see in the pcap file in > comment #7, even the simplest case, a single url in firefox, firefox does > send data to gnome-shell, but gnome-shell does not display anything. In this > case the website was both bookmarked and visited. I think the metadata sent back to gnome-shell are somehow corrupted so I'd need to investigate the Metadata reply. It works now with firefox-77.0.1-2.fc32.x86_64 and gnome-shell-3.36.3-3.fc32.x86_64. I don't exactly know since when though. |