Bug 1790560

Summary: [OCS-3.11.z][TRACKING TICKET] gluster-block-target.service not starting after a reboot with a genconfig failure
Product: [Red Hat Storage] Red Hat Gluster Storage Reporter: Andre Costa <andcosta>
Component: gluster-blockAssignee: Prasanna Kumar Kalever <prasanna.kalever>
Status: CLOSED ERRATA QA Contact: Arun Kumar <arukumar>
Severity: high Docs Contact:
Priority: unspecified    
Version: ocs-3.11CC: arukumar, jmulligan, pkarampu, pprakash, prasanna.kalever, puebele, rhs-bugs, sabose, vbellur, xiubli
Target Milestone: ---Keywords: ZStream
Target Release: OCS 3.11.z Batch Update 5   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: gluster-block-0.2.1-35.el7rhgs Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-02-26 20:05:00 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Andre Costa 2020-01-13 15:52:25 UTC 
Description of problem:
As mention in ticket https://bugzilla.redhat.com/show_bug.cgi?id=1787371, this ticket is to track the fix on the next releases of OCS 3.11.z

Version-Release number of selected component (if applicable):
OCS 3.11.4
Comment 6 Prasanna Kumar Kalever 2020-01-31 07:25:00 UTC 
Problem Statement:
gluster-block-target.service fails to start, after upgrading because there is an empty block config file. The empty config file was created because of the genconfig failure, which runs after every upgrade.


Version:
All OCS versions

Root Cause:
The genconfig was failing in case if there are more than 6 Block Hosting Volumes (BHVs). This is because the genconfig cli rpc buffer holding BHV list is static now and is set to hold only 255 chars only.

Fix Status:
Merged upstream.
Very small change, fix the buffer size to allocate dynamically.


Is this a regression:
No, it's there since the introduction of genconfig feature i.e from rhgs-3.3.1 release of gluster-block.


How to test the changes:
Note this is only the cli side change around genconfig command and hence it doesn't affect other commands workflow. From my review, this change will not lead to any regressions.
The test would be to run genconfig with more than 6 BHV's i.e  '# gluster-block genconfig <BHV1, BHV2.....BHVn> enable-tpg <IP>'
Comment 12 errata-xmlrpc 2020-02-26 20:05:00 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0621