Bug 1790757

Summary:	Should not create secret if idp is not created successfully
Product:	OpenShift Container Platform	Reporter:	Yanping Zhang <yanpzhan>
Component:	Management Console	Assignee:	Jakub Hadvig <jhadvig>
Status:	CLOSED ERRATA	QA Contact:	Yadan Pei <yapei>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	4.3.0	CC:	aos-bugs, jhadvig, jokerman, spadgett
Target Milestone:	---
Target Release:	4.4.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1790863 (view as bug list)		Environment:
Last Closed:	2020-05-04 11:24:06 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1790863

Description Yanping Zhang 2020-01-14 05:57:57 UTC

Description of problem:
When do negative test for idp, the idp is not created successfully but secret is already created.

Version-Release number of selected component (if applicable):
4.3.0-0.nightly-2020-01-11-070223

How reproducible:
Always

Steps to Reproduce:
1.Create gitlab idp from console, set name, client id, client secret, and input "testurl" in field "URL", click "Add".
2.Check secret in openshift-config project.
3.

Actual results:
1. It will prompt error: "must contain a scheme (e.g. https://)" for field "spec.identityProviders[1].gitlab.url"."
2. New secret prefix with "gitlab-client-secret" is listed in openshift-config project.

Expected results:
2. Should not create secret if idp is not created successfully.


Additional info:

Comment 2 Yanping Zhang 2020-01-19 06:38:38 UTC

Tested on OCP 4.3 with payload 4.4.0-0.nightly-2020-01-18-223038, tried to create gitlab idp with some field invalid, after creation failed, checked secret under openshift-config project, no new secret was created.
The bug is fixed, so move it to Verified.

Comment 3 Jakub Hadvig 2020-01-23 12:07:25 UTC

*** Bug 1790863 has been marked as a duplicate of this bug. ***

Comment 5 errata-xmlrpc 2020-05-04 11:24:06 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581