Bug 179103

Summary: v2 quota support is broken
Product: Red Hat Enterprise Linux 3 Reporter: Bastien Nocera <bnocera>
Component: sambaAssignee: Jay Fenlason <fenlason>
Status: CLOSED ERRATA QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: 3.0CC: jfeeney, tao
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: RHBA-2006-0364 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2006-07-20 14:49:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 181405    
Attachments:
Description Flags
samba-unbreak-v2-quota-support.patch none

Description Bastien Nocera 2006-01-27 14:23:40 UTC 
samba-3.0.9-1.3E.7

When using samba after having implemented quotas:
[2006/01/18 05:50:03, 3] lib/sysquotas.c:sys_get_quota(413)
 sys_get_vfs_quota() failed for mntpath[/test] bdev[/dev/VolGroup01/testlv]
qtype[2] id[10056]: Invalid argument
[2006/01/18 05:50:03, 3] smbd/reply.c:reply_dskattr(785)
 dskattr dfree=58104
[2006/01/18 05:50:03, 5] lib/util.c:show_msg(486)
[2006/01/18 05:50:03, 5] lib/util.c:show_msg(496)

To be able to support both quota v1 and v2, samba is defined its own constants
for the cmd part of quotactl()'s QCMD. However, the v2 constants in the system
headers and samba don't match.

 In source/include/samba_linux_quota.h:
#ifndef Q_V2_GETQUOTA
#define Q_V2_GETQUOTA  0x0D00
#endif #ifndef Q_V2_SETQUOTA
#define Q_V2_SETQUOTA  0x0E00
#endif

And in sys/quota.h:
# define Q_GETQUOTA 0x800007    /* get user quota structure */
# define Q_SETQUOTA 0x800008    /* set user quota structure */

Patch attached.
Comment 1 Bastien Nocera 2006-01-27 14:23:41 UTC 
Created attachment 123778 [details]
samba-unbreak-v2-quota-support.patch
Comment 2 Bastien Nocera 2006-01-27 14:30:26 UTC 
The problem also exists with RHEL4 and upstream:
http://websvn.samba.org/cgi-bin/viewcvs.cgi/branches/SAMBA_3_0/source/include/samba_linux_quota.h?rev=3&view=markup

Upstream BZ:
https://bugzilla.samba.org/show_bug.cgi?id=3456
Comment 5 Bob Johnson 2006-04-11 16:31:44 UTC 
This issue is on Red Hat Engineering's list of planned work items 
for the upcoming Red Hat Enterprise Linux 3.8 release.  Engineering 
resources have been assigned and barring unforeseen circumstances, Red 
Hat intends to include this item in the 3.8 release.
Comment 9 Red Hat Bugzilla 2006-07-20 14:49:25 UTC 
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2006-0364.html