Bug 1791107

Summary: vimiv-qt needs python3-qt5 for SVG support
Product: [Fedora] Fedora Reporter: Akos Ladanyi <akos.ladanyi>
Component: vimiv-qtAssignee: Ankur Sinha (FranciscoD) <sanjay.ankur>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: sanjay.ankur
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: vimiv-qt-0.5.0-2.fc30 vimiv-qt-0.5.0-2.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-31 01:13:09 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Akos Ladanyi 2020-01-14 21:07:38 UTC
vimiv-qt cannot display SVG files because of missing dependency on the python3-qt5-webengine package.

Comment 1 Ankur Sinha (FranciscoD) 2020-01-15 09:49:59 UTC
Can you please confirm the output before and after you install python3-qt5-webengine? Were any other packages installed as dependencies?

The documentation says that it needs QtSvg which is included in python3-qt5:
$ rpm -qf /usr/lib64/python3.7/site-packages/PyQt5/QtSvg.so
python3-qt5-5.13.1-1.fc31.x86_64

The source seems to confirm this also:
https://github.com/karlch/vimiv-qt/blob/master/vimiv/imutils/_file_handler.py#L23

At a quick glance, I've not been able to see where webengine would be needed.

Comment 2 Akos Ladanyi 2020-01-16 02:08:15 UTC
Sorry, I got this wrong. The real missing dependency is python3-qt.

Comment 3 Akos Ladanyi 2020-01-16 02:10:15 UTC
(In reply to Akos Ladanyi from comment #2)
> Sorry, I got this wrong. The real missing dependency is python3-qt.

I ment python3-qt5.

Comment 4 Ankur Sinha (FranciscoD) 2020-01-20 10:22:28 UTC
Hrm, but that is already included in the requirements:

$ rpm -q --requires vimiv-qt
/usr/bin/python3
hicolor-icon-theme
libc.so.6()(64bit)
libc.so.6(GLIBC_2.2.5)(64bit)
libc.so.6(GLIBC_2.4)(64bit)
libpython3.7m.so.1.0()(64bit)
python(abi) = 3.7
python3-piexif
python3.7dist(pyqt5) >= 5.9.2      <-----------------------
python3.7dist(setuptools)
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PartialHardlinkSets) <= 4.0.4-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsZstd) <= 5.4.18-1
rtld(GNU_HASH)


Can you please describe the error you are seeing? This may need some looking into.

Comment 5 Akos Ladanyi 2020-01-20 19:16:00 UTC
This is what I see:

# vimiv -v
vimiv v0.3.0

Python: 3.7.6
Qt: 5.13.2
PyQt: 5.13.2

Svg Support: True 
Piexif: 1.1.3
# dnf remove vimiv-qt python3-qt5
Dependencies resolved.
============================================================================================================================================
 Package                                Architecture                Version                             Repository                     Size
============================================================================================================================================
Removing:
 python3-qt5                            x86_64                      5.13.2-3.fc31                       @updates                      6.7 M
 vimiv-qt                               x86_64                      0.3.0-1.fc31                        @updates                      928 k
Removing unused dependencies:
 python3-piexif                         noarch                      1.1.3-2.fc31                        @fedora                       123 k
 python3-pyqt5-sip                      x86_64                      4.19.19-1.fc31                      @updates                      241 k
 python3-qt5-base                       x86_64                      5.13.2-3.fc31                       @updates                       17 M

Transaction Summary
============================================================================================================================================
Remove  5 Packages

Freed space: 25 M
Is this ok [y/N]: y
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                    1/1 
  Erasing          : vimiv-qt-0.3.0-1.fc31.x86_64                                                                                       1/5 
  Erasing          : python3-qt5-5.13.2-3.fc31.x86_64                                                                                   2/5 
  Erasing          : python3-piexif-1.1.3-2.fc31.noarch                                                                                 3/5 
  Erasing          : python3-qt5-base-5.13.2-3.fc31.x86_64                                                                              4/5 
  Erasing          : python3-pyqt5-sip-4.19.19-1.fc31.x86_64                                                                            5/5 
  Running scriptlet: python3-pyqt5-sip-4.19.19-1.fc31.x86_64                                                                            5/5 
  Verifying        : python3-piexif-1.1.3-2.fc31.noarch                                                                                 1/5 
  Verifying        : python3-pyqt5-sip-4.19.19-1.fc31.x86_64                                                                            2/5 
  Verifying        : python3-qt5-5.13.2-3.fc31.x86_64                                                                                   3/5 
  Verifying        : python3-qt5-base-5.13.2-3.fc31.x86_64                                                                              4/5 
  Verifying        : vimiv-qt-0.3.0-1.fc31.x86_64                                                                                       5/5 

Removed:
  python3-qt5-5.13.2-3.fc31.x86_64                vimiv-qt-0.3.0-1.fc31.x86_64                  python3-piexif-1.1.3-2.fc31.noarch        
  python3-pyqt5-sip-4.19.19-1.fc31.x86_64         python3-qt5-base-5.13.2-3.fc31.x86_64        

Complete!
# dnf install vimiv-qt
Last metadata expiration check: 2:36:17 ago on Mon 20 Jan 2020 05:34:24 PM CET.
Dependencies resolved.
============================================================================================================================================
 Package                                Architecture                Version                              Repository                    Size
============================================================================================================================================
Installing:
 vimiv-qt                               x86_64                      0.3.0-1.fc31                         updates                      298 k
Installing dependencies:
 python3-pyqt5-sip                      x86_64                      4.19.19-1.fc31                       updates                       94 k
 python3-qt5-base                       x86_64                      5.13.2-3.fc31                        updates                      3.2 M
 python3-piexif                         noarch                      1.1.3-2.fc31                         fedora                        45 k

Transaction Summary
============================================================================================================================================
Install  4 Packages

Total download size: 3.6 M
Installed size: 19 M
Is this ok [y/N]: y
Downloading Packages:
(1/4): python3-pyqt5-sip-4.19.19-1.fc31.x86_64.rpm                                                          463 kB/s |  94 kB     00:00    
(2/4): python3-piexif-1.1.3-2.fc31.noarch.rpm                                                               1.7 MB/s |  45 kB     00:00    
(3/4): vimiv-qt-0.3.0-1.fc31.x86_64.rpm                                                                     669 kB/s | 298 kB     00:00    
(4/4): python3-qt5-base-5.13.2-3.fc31.x86_64.rpm                                                            4.0 MB/s | 3.2 MB     00:00    
--------------------------------------------------------------------------------------------------------------------------------------------
Total                                                                                                       1.9 MB/s | 3.6 MB     00:01     
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
  Preparing        :                                                                                                                    1/1 
  Installing       : python3-piexif-1.1.3-2.fc31.noarch                                                                                 1/4 
  Installing       : python3-pyqt5-sip-4.19.19-1.fc31.x86_64                                                                            2/4 
  Installing       : python3-qt5-base-5.13.2-3.fc31.x86_64                                                                              3/4 
  Installing       : vimiv-qt-0.3.0-1.fc31.x86_64                                                                                       4/4 
  Running scriptlet: vimiv-qt-0.3.0-1.fc31.x86_64                                                                                       4/4 
  Verifying        : python3-pyqt5-sip-4.19.19-1.fc31.x86_64                                                                            1/4 
  Verifying        : python3-qt5-base-5.13.2-3.fc31.x86_64                                                                              2/4 
  Verifying        : vimiv-qt-0.3.0-1.fc31.x86_64                                                                                       3/4 
  Verifying        : python3-piexif-1.1.3-2.fc31.noarch                                                                                 4/4 

Installed:
  vimiv-qt-0.3.0-1.fc31.x86_64               python3-pyqt5-sip-4.19.19-1.fc31.x86_64         python3-qt5-base-5.13.2-3.fc31.x86_64        
  python3-piexif-1.1.3-2.fc31.noarch        

Complete!
# vimiv -v
vimiv v0.3.0

Python: 3.7.6
Qt: 5.13.2
PyQt: 5.13.2

Svg Support: False 
Piexif: 1.1.3

Comment 6 Ankur Sinha (FranciscoD) 2020-01-21 20:30:45 UTC
Ah, that makes sense. Seems like only python3-qt5-base is included as an autogenerated dependency:

$ rpm -q --provides python3-qt5-base
python-qt5-base = 5.13.1-1.fc31
python3-PyQt5-base = 5.13.1-1.fc31
python3-PyQt5-base(x86-64) = 5.13.1-1.fc31
python3-qt5-base = 5.13.1-1.fc31
python3-qt5-base(x86-64) = 5.13.1-1.fc31
python3.7dist(pyqt5) = 5.13.1
python3dist(pyqt5) = 5.13.1


For the SVG bits, we need python3-qt5:
$ rpmls python3-qt5 | grep -i svg
-rw-r--r--  /usr/lib64/python3.7/site-packages/PyQt5/QtSvg.pyi
-rwxr-xr-x  /usr/lib64/python3.7/site-packages/PyQt5/QtSvg.so


I'll add this and push an update now.

Thanks!

Comment 7 Fedora Update System 2020-01-21 20:58:39 UTC
FEDORA-2020-81cedc4fcc has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-81cedc4fcc

Comment 8 Fedora Update System 2020-01-22 01:56:37 UTC
vimiv-qt-0.5.0-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-9f2cbe879a

Comment 9 Fedora Update System 2020-01-24 05:49:43 UTC
vimiv-qt-0.5.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-81cedc4fcc

Comment 10 Fedora Update System 2020-01-31 01:13:09 UTC
vimiv-qt-0.5.0-2.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 11 Fedora Update System 2020-02-01 01:30:32 UTC
vimiv-qt-0.5.0-2.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.