Bug 1791478

Summary: Cannot completely disable odrs (Gnome Ratings) from the Software application in Gnome Desktop
Product: Red Hat Enterprise Linux 8 Reporter: Jacob Hunt <jhunt>
Component: gnome-softwareAssignee: Milan Crha <mcrha>
Status: CLOSED ERRATA QA Contact: Martin Krajnak <mkrajnak>
Severity: high Docs Contact:
Priority: unspecified    
Version: 8.1CC: klember, mkrajnak, rhughes, tpelka, tpopela
Target Milestone: rcKeywords: Triaged
Target Release: 8.4Flags: pm-rhel: mirror+
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: gnome-software-3.36.1-6.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-11-09 19:33:50 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot of error none

Description Jacob Hunt 2020-01-15 22:12:13 UTC
Created attachment 1652580 [details]
Screenshot of error

Description of problem:

If site policy rules don't allow access to odrs.gnome.org, there isn't a configuration available to completely disable the Gnome Ratings.

Version-Release number of selected component (if applicable):

gnome-software-3.30.6-2.el8

How reproducible:

100%

Steps to Reproduce:
1. Install an RHEL 8 virtual system, make sure to not enable networking.
2. As a normal user launch 'gnome-software'
3. Edit /etc/dconf/db/local.d/00-software with the following contents.

# dconf path
[org/gnome/software]

# GSettings key names and their corresponding values
enable-shell-extensions-repo='false'
review-server=''

4. Make it site-wide mandatory by creating the following file /etc/dconf/db/local.d/locks/software with the contents.

/org/gnome/software/enable-shell-extensions-repo

5. Update the system databases

# dconf update

Actual results:

You get an error dialog that it can't resolve odrs.gnome.org

Expected results:

That the rating system is disabled, and you don't see an error dialog

Comment 2 Richard Hughes 2020-09-21 07:34:26 UTC
Sure, we could add this as a GSetting or even just split out the ODRS plugin as a subpackage.

Comment 10 Milan Crha 2021-02-16 12:56:43 UTC
(In reply to Martin Krajnak from comment #9)
> I support the idea of disabling that in RHEL, it also has it's issues
> outside RHEL as discussed here:
> https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1010

It's not an upstream mirror of this bug.

I think there can be the third option, ignore connection errors to the ODRS server, though maybe not that great for upstream.

That being said, which route to go?
a) on the RHEL side, package the ODRS plugin separately and Recommend it in the main package;
b) add an upstream option to disable the ODRS plugin in runtime;
c) ignore connection errors.

The a) might be the most problematic, you do not want to diverge from the Fedora packaging for sure.

The b) - looking more closely, the option is already there, it's even mentioned in the description above, the 'review-server' GSettings key. The problem is that: 1) its change requires gnome-software restart; 2) filling an empty value is not meant as being disabled.

The best will be to fix things upstream for the b) and eventually backport that change. I opened [1] for it:
https://gitlab.gnome.org/GNOME/gnome-software/-/issues/1143

Comment 12 Martin Krajnak 2021-05-24 14:22:31 UTC
Reproducer:

1.From terminal execute:
  $ gsettings set org.gnome.software review-server ''
  $ pkill gnome-software
2.Close terminal and start gnome-sofware from the gnome-shell overview.
3.Review section is hidden for every application

gnome-software-3.36.1-8.el8.x86_64

Comment 17 errata-xmlrpc 2021-11-09 19:33:50 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: GNOME security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2021:4381