Bug 1791543

Summary:	[machines] Network interfaces will be deleted until there is just one left
Product:	Red Hat Enterprise Linux 8	Reporter:	YunmingYang <yunyang>
Component:	cockpit-appstream	Assignee:	Katerina Koukiou <kkoukiou>
Status:	CLOSED ERRATA	QA Contact:	YunmingYang <yunyang>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.2	CC:	kkoukiou, leiwang, mmarusak, mpitt, wshi, xchen, ymao
Target Milestone:	rc
Target Release:	8.2
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-28 15:43:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description YunmingYang 2020-01-16 06:20:54 UTC

Description of problem:
This issue happens when there is a network interface with a wrong characters for its source in the middle of the network interfaces.

Version-Release number of selected component (if applicable):
cockpit-machines-210-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare a VM and a linux bridge
2. Switch to the 'Network Interfaces' tab of the VM
3. Add a network interface whose 'Interface Type' is 'Bridge to LAN'
4. Add another network interface whose 'Interface Type' is 'Virtual Network'
5. Click 'Edit' button of the network interface whose 'Interface Type' is 'Bridge to LAN'
6. Click 'Save' without changing
7. Click 'Delete' button of the network interface whose 'Interface Type' is 'Bridge to LAN', then Click 'Delete' of the popup dialog

Actual results:
1. After step 6, the source of the network interface whose 'Interface Type' is 'Bridge to LAN' will be changed to wrong characters.
2. After step 7, the popup dialog will not be closed immediately, and clicking 'Delete' button of popup dialog will delete other network interfaces until there is just one left 

Expected results:
1. After clicking 'Delete' button of popup dialog, the dialog will be closed immediately.

Additional info:

Comment 1 Martin Pitt 2020-01-16 17:59:31 UTC

Katerina fixes this in https://github.com/cockpit-project/cockpit/pull/13408 , thanks!

Comment 3 Xianghua Chen 2020-02-04 10:10:00 UTC

Failed with package:
cockpit-machines-211-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

Steps:
1. Prepare a off VM and a linux bridge
2. Switch to the 'Network Interfaces' tab of the VM
3. Add a network interface whose 'Interface Type' is 'Bridge to LAN'
4. Add another network interface whose 'Interface Type' is 'Virtual Network'
5. Click 'Edit' button of the network interface whose 'Interface Type' is 'Bridge to LAN'
6. Click 'Save' without changing
7. Click 'Delete' button of the network interface whose 'Interface Type' is 'Bridge to LAN', then Click 'Delete' of the popup dialog

Actual results:
1. After step 6, the source of the network interface whose 'Interface Type' is 'Bridge to LAN' will not be changed. -- fixed
2. After step 7, the popup dialog will not be closed immediately, and clicking 'Delete' button of popup dialog will delete other network interfaces until there is just one left  -- not fixed

Comment 4 Martin Pitt 2020-02-05 16:16:13 UTC

https://github.com/cockpit-project/cockpit/pull/13488

Comment 5 Martin Pitt 2020-02-19 16:43:26 UTC

I updated the advisory to upstream release 211.2, which should have this fixed.

Comment 6 Xianghua Chen 2020-02-21 10:47:55 UTC

Verified with package:
cockpit-machines-211.2-1.el8.noarch

Steps:
1. Prepare a VM and a linux bridge
2. Switch to the 'Network Interfaces' tab of the VM
3. Add a network interface whose 'Interface Type' is 'Bridge to LAN'
4. Add another network interface whose 'Interface Type' is 'Virtual Network'
5. Click 'Edit' button of the network interface whose 'Interface Type' is 'Bridge to LAN'
6. Click 'Save' without changing
7. Click 'Delete' button of the network interface whose 'Interface Type' is 'Bridge to LAN', then Click 'Delete' of the popup dialog

In step 6, the source of the network interface whose 'Interface Type' is 'Bridge to LAN' will not be changed to wrong characters.
In step 7, the popup dialog will be closed immediately. 

So verified.

Comment 8 errata-xmlrpc 2020-04-28 15:43:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639