Bug 1791952

Summary: gyp fails to build with Python 3.9: imports abc from collections
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: gypAssignee: Akira TAGOH <tagoh>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, hugovk+redhatbugzilla, mhroncok, tagoh
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-21 10:07:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415    

Description Miro Hrončok 2020-01-16 18:56:57 UTC
gyp fails to build with Python 3.9.0a2.

    Traceback (most recent call last):
      File "/builddir/build/BUILD/gyp-0.1-gitfcd686f1/gyp_main.py", line 13, in <module>
        import gyp
      File "/builddir/build/BUILD/gyp-0.1-gitfcd686f1/pylib/gyp/__init__.py", line 9, in <module>
        import gyp.input
      File "/builddir/build/BUILD/gyp-0.1-gitfcd686f1/pylib/gyp/input.py", line 8, in <module>
        import gyp.common
      File "/builddir/build/BUILD/gyp-0.1-gitfcd686f1/pylib/gyp/common.py", line 497, in <module>
        class OrderedSet(collections.MutableSet):
    AttributeError: module 'collections' has no attribute 'MutableSet'

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The abstract base classes in collections.abc no longer are exposed in the regular collections module. This will help create a clearer distinction between the concrete classes and the abstract base classes."



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01148437-gyp/

For all our attempts to build gyp with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/gyp/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Hugo van Kemenade 2020-01-20 20:48:00 UTC
This was fixed in PR https://github.com/nodejs/node-gyp/pull/1961 (Nov 2019) and was released in 5.0.6 (Dec 2019, there's also been a 5.0.7 in Dec 2019) and 6.1.0 (Jan 2020).

https://github.com/nodejs/node-gyp/releases

Please update to a later version.

Comment 2 Miro Hrončok 2020-01-21 10:07:37 UTC
Thank You for the quick fix.