Bug 1791971

Summary: pygame fails to build with Python 3.9: 'array.array' object has no attribute 'tostring'
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: pygameAssignee: Jaroslav Škarvada <jskarvad>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, gwync, jkaluza, jskarvad, mhroncok
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-17 21:27:13 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415    

Description Miro Hrončok 2020-01-16 19:17:18 UTC
pygame fails to build with Python 3.9.0a2.

======================================================================
ERROR: testLoadPNG (__main__.ImageModuleTest)
see if we can load a png with color values in the proper channels.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pygame-1.9.6/test/image_test.py", line 57, in testLoadPNG
    w.write(f, pixel_array)
  File "/builddir/build/BUILDROOT/pygame-1.9.6-5.fc32.x86_64/usr/lib64/python3.9/site-packages/pygame/tests/test_utils/png.py", line 617, in write
    nrows = self.write_passes(outfile, rows)
  File "/builddir/build/BUILDROOT/pygame-1.9.6-5.fc32.x86_64/usr/lib64/python3.9/site-packages/pygame/tests/test_utils/png.py", line 783, in write_passes
    compressed = compressor.compress(tostring(data))
  File "/builddir/build/BUILDROOT/pygame-1.9.6-5.fc32.x86_64/usr/lib64/python3.9/site-packages/pygame/tests/test_utils/png.py", line 205, in tostring
    return row.tostring()
AttributeError: 'array.array' object has no attribute 'tostring'

======================================================================
ERROR: test_fromstring__and_tostring (__main__.ImageModuleTest)
Ensure methods tostring() and fromstring() are symmetric.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/pygame-1.9.6/test/image_test.py", line 419, in test_fromstring__and_tostring
    rgba_buf = RotateARGBtoRGBA(RotateRGBAtoARGB(rgba_buf))
  File "/builddir/build/BUILD/pygame-1.9.6/test/image_test.py", line 390, in RotateRGBAtoARGB
    return byte_buf.tostring()
AttributeError: 'array.array' object has no attribute 'tostring'


See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"array.array: tostring() and fromstring() methods have been removed. They were aliases to tobytes() and frombytes(), deprecated since Python 3.2.


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01148668-pygame/

For all our attempts to build pygame with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/pygame/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.