Bug 1792379

Summary:	[machines] The remove disk dialog can not be closed when delete sata disk until all the disks are deleted
Product:	Red Hat Enterprise Linux 8	Reporter:	Xianghua Chen <xchen>
Component:	cockpit-appstream	Assignee:	Simon Kobyda <skobyda>
Status:	CLOSED ERRATA	QA Contact:	Xianghua Chen <xchen>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	8.2	CC:	kkoukiou, mmarusak, mpitt, skobyda, ymao, yunyang
Target Milestone:	rc
Target Release:	8.2
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-28 15:43:08 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Xianghua Chen 2020-01-17 15:15:55 UTC

Description of problem:
The remove disk dialog can not be closed when delete sata disk until all the disks are deleted

Version-Release number of selected component (if applicable):
cockpit-machines-210-1.el8.noarch
libvirt-dbus-1.2.0-3.module+el8.1.0+4066+0f1aadab.x86_64

How reproducible:
100%

Steps to Reproduce:
1. Prepare an off VM
2. Enter Disk tab, click Add Disk
  Source:Create New
  Pool:images
  Name:test1
  Size:1
  Format:qcow2
  Cache:default
  Bus:virtio
Click Add
3. Repeat step 2, set:
  Name:test2
  Bus: sata
Click Add
4. Click Remove for test2 whose Bugs type is sata
5. Click Remove on the dialog, the test2 is deleted , but the dialog is still there


Actual results:
The remove dialog can not be closed until keep on clicking remove and get all the disks removed.

Expected results:
The dialog will be closed and the sata disk can be deleted in step 5

Additional info:

Comment 1 Simon Kobyda 2020-01-23 12:00:02 UTC

PR fix:
https://github.com/cockpit-project/cockpit/pull/13436

Comment 2 Katerina Koukiou 2020-02-12 12:17:47 UTC

Fixed upstream with:

commit cbadcfc7ecd3e4e85c93b8030e67f2e647545049
Author: Katerina Koukiou <kkoukiou>
Date:   Mon Feb 3 23:22:28 2020 +0100

    machines: fix issue with Disk Delete dialog not closing when deleting a disk

Comment 5 Xianghua Chen 2020-02-21 06:38:17 UTC

Verified with package:
cockpit-machines-211.2-1.el8.noarch

Steps:
1. Prepare an off VM
2. Enter Disk tab, click Add Disk
  Source:Create New
  Pool:images
  Name:test1
  Size:1
  Format:qcow2
  Cache:default
  Bus:virtio
Click Add
3. Repeat step 2, set:
  Name:test2
  Bus: sata
Click Add
4. Click Remove for test2 whose Bugs type is sata
5. Click Remove on the dialog

The test2 is deleted , and the dialog is closed.So verified.

Comment 7 errata-xmlrpc 2020-04-28 15:43:08 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:1639