Bug 1792564

Summary: Consider enabling CONFIG_PCIE_ROCKCHIP_HOST and CONFIG_PHY_ROCKCHIP_PCIE as modules.
Product: [Fedora] Fedora Reporter: Luke Yelavich <themuso>
Component: kernelAssignee: Kernel Maintainer List <kernel-maint>
Status: CLOSED DUPLICATE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: airlied, bskeggs, hdegoede, ichavero, itamar, jarodwilson, jcline, jeremy, jglisse, john.j5live, jonathan, josef, kernel-maint, linville, masami256, mchehab, mjg59, pbrobinson, steved
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: aarch64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-02-11 11:01:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Luke Yelavich 2020-01-18 00:54:13 UTC
1. Please describe the problem:

The configuration options in the summary are not currently enabled in Fedora 31 or rawhide. Enabling these to build as modules allows the use of PCI Express devices on boards using RockChip SoCs such as the RockPro64.


2. What is the Version-Release number of the kernel:

Kernel 5.4.12 in Fedora 31, but the kernel packaging on pagure for rawhide also has these currently disabled.


3. Did it work previously in Fedora? If so, what kernel version did the issue
   *first* appear?  Old kernels are available for download at
   https://koji.fedoraproject.org/koji/packageinfo?packageID=8 :
I don't think these config options have ever been enabled

4. Can you reproduce this issue? If so, please provide the steps to reproduce
   the issue below
I have a RockPro64 running Fedora 31, and cannot use the connected SATA PCIE card. Rebuilding the kernel locally with these options enabled as modules allows me to use the attached drives on the SATA card.

5. Does this problem occur with the latest Rawhide kernel? To install the
   Rawhide kernel, run ``sudo dnf install fedora-repos-rawhide`` followed by
   ``sudo dnf update --enablerepo=rawhide kernel``:
Have not actually tested on rawhide, but checking the packaging, I suspect it would not.

6. Are you running any modules that not shipped with directly Fedora's kernel?:

No.

7. Please attach the kernel logs. You can get the complete kernel log
   for a boot with ``journalctl --no-hostname -k > dmesg.txt``. If the
   issue occurred on a previous boot, use the journalctl ``-b`` flag.

No logs currently, don't really think any are really necessary, but can grab them if required.

Comment 1 Jeremy Cline 2020-02-07 19:40:22 UTC
Hi,

I've enabled both of these modules in Rawhide starting with kernel-5.6.0-0.rc0.git5.1.fc32 and I've dropped it into the v5.5 rebase for stable Fedora releases.

Comment 2 Peter Robinson 2020-02-11 09:14:40 UTC
This was explicitly disabled because it caused issues across a number of devices. Who is on the hook to deal with those issues?

Comment 3 Peter Robinson 2020-02-11 11:01:59 UTC
Still an issue: [   33.654926] rockchip-pcie f8000000.pcie: PCIe link training gen1 timeout!

And this is a duplicate where it's well where this is well documented.

*** This bug has been marked as a duplicate of bug 1704945 ***

Comment 4 Jeremy Cline 2020-02-11 14:35:17 UTC
Whoops, sorry. I either forgot or missed it. I'll flip it back off.

Comment 5 Peter Robinson 2020-02-11 14:37:09 UTC
(In reply to Jeremy Cline from comment #4)
> Whoops, sorry. I either forgot or missed it. I'll flip it back off.

already did

Comment 6 Jeremy Cline 2020-02-11 14:44:20 UTC
Thanks.

I do look at the git history of a config, so linking to bugzillas (as you did when you turned this back off) should keep me from forgetfully flipping things back on that are known to be broken.