Bug 1792623

Summary: Graphs CPU page shows Ooops
Product: [Fedora] Fedora Reporter: Mace Moneta <moneta.mace>
Component: cockpitAssignee: Martin Pitt <mpitt>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 30CC: dperpeet, eugenemah, ichavero, mmarusak, moneta.mace, stefw
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-211-1.fc31 cockpit-211.1-1.fc31 cockpit-212-1.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-27 11:26:11 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Screenshot of Chrome console none

Description Mace Moneta 2020-01-18 14:19:14 UTC
Created attachment 1653368 [details]
Screenshot of Chrome console

Description of problem:
Running on Fedora 30, going to graphs CPU page shows Ooops.

Version-Release number of selected component (if applicable):
cockpit-210-1.fc30.x86_64

How reproducible:
Always

Steps to Reproduce:
1.Login to cockpit
2.In "Usage" section, click "View graphs"
3.Click on CPU cores to display CPU usage
4.Get "Ooops!" 

Actual results:
Ooops

Expected results:
Graph of CPU usage

Additional info:
Chrome Version 79.0.3945.123 (Official Build) (64-bit)

Comment 1 Mace Moneta 2020-01-18 14:23:04 UTC
Same problem on "Memory & Swap" graph, but "Disk I/O" and "Network Traffic" graphs work fine.

Comment 2 Martin Pitt 2020-01-20 09:15:44 UTC
This may not be completely right, but at least fixes things for me and the original reporter: https://github.com/cockpit-project/cockpit/pull/13420

Comment 3 Fedora Update System 2020-01-22 21:43:16 UTC
FEDORA-2020-e70cf11146 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e70cf11146

Comment 4 Eugene Mah 2020-01-23 00:13:24 UTC
After installing cockpit-211-1.fc31.x86_64, the overview usage graphs page shows the graphs fine, but clicking through to the CPU and memory graphs still throw Javascript errors on my system



    Uncaught Error: Invalid dimensions for plot, width = 735, height = 0
        at a.resize (graphs.js:1)
        at new a (graphs.js:1)
        at graphs.js:1
        at new n (graphs.js:1)
        at Function.e.plot (graphs.js:1)
        at c (graphs.js:1)
        at Object.start (graphs.js:1)
        at Function.<anonymous> (graphs.js:1)
        at s (cockpit.js:979)
        at cockpit.js:991

Comment 5 Mace Moneta 2020-01-23 00:16:16 UTC
I can confirm the problem still exists. Also, when installing the update, I get:

Running transaction
  Preparing        :                                                                                                    1/1
  Running scriptlet: cockpit-ws-211-1.fc30.x86_64                                                                       1/1
  Running scriptlet: cockpit-ws-211-1.fc30.x86_64                                                                       1/6
  Upgrading        : cockpit-ws-211-1.fc30.x86_64                                                                       1/6
  Running scriptlet: cockpit-ws-211-1.fc30.x86_64                                                                       1/6
  Upgrading        : cockpit-bridge-211-1.fc30.x86_64                                                                   2/6
  Upgrading        : cockpit-211-1.fc30.x86_64                                                                          3/6
  Cleanup          : cockpit-210-1.fc30.x86_64                                                                          4/6
  Cleanup          : cockpit-bridge-210-1.fc30.x86_64                                                                   5/6
  Running scriptlet: cockpit-ws-210-1.fc30.x86_64                                                                       6/6
  Cleanup          : cockpit-ws-210-1.fc30.x86_64                                                                       6/6
  Running scriptlet: cockpit-ws-210-1.fc30.x86_64                                                                       6/6
warning: %triggerin(systemd-241-12.git323cdf4.fc30.x86_64) scriptlet failed, exit status 73

Error in <unknown> scriptlet in rpm package cockpit-ws                                                                  
  Verifying        : cockpit-211-1.fc30.x86_64                                                                          1/6
  Verifying        : cockpit-210-1.fc30.x86_64                                                                          2/6
  Verifying        : cockpit-bridge-211-1.fc30.x86_64                                                                   3/6
  Verifying        : cockpit-bridge-210-1.fc30.x86_64                                                                   4/6
  Verifying        : cockpit-ws-211-1.fc30.x86_64                                                                       5/6
  Verifying        : cockpit-ws-210-1.fc30.x86_64                                                                       6/6

Upgraded:
  cockpit-211-1.fc30.x86_64            cockpit-bridge-211-1.fc30.x86_64            cockpit-ws-211-1.fc30.x86_64

Complete!

Comment 6 Matej Marušák 2020-01-23 09:07:52 UTC
I tested it and it seems to work. Have you stopped the `cockpit.service` and refreshed cockpit? What browser are you using?

Comment 7 Mace Moneta 2020-01-23 13:07:25 UTC
Yes, cockpit was restarted via systemctl. Still the same browser: Chrome Version 79.0.3945.123.

Comment 8 Martin Pitt 2020-01-23 16:47:28 UTC
Argh, how embarrassing! Fixed in https://github.com/cockpit-project/cockpit/pull/13433 and reproduced in a test case in https://github.com/cockpit-project/cockpit/pull/13439

Comment 9 Fedora Update System 2020-01-24 19:47:24 UTC
cockpit-211-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e70cf11146

Comment 10 Fedora Update System 2020-01-25 08:18:01 UTC
cockpit-211-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d5974928d6

Comment 11 Mace Moneta 2020-01-26 00:56:29 UTC
Confirming that the issue has been corrected.

Comment 12 Fedora Update System 2020-01-26 10:12:01 UTC
FEDORA-2020-99d5fe0b31 has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-99d5fe0b31

Comment 13 Fedora Update System 2020-01-27 11:26:11 UTC
cockpit-211-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 14 Fedora Update System 2020-01-31 01:28:04 UTC
cockpit-211.1-1.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-99d5fe0b31

Comment 15 Fedora Update System 2020-01-31 02:25:10 UTC
cockpit-211.1-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-13dea2829c

Comment 16 Fedora Update System 2020-02-01 01:30:38 UTC
cockpit-211.1-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 17 Fedora Update System 2020-02-07 01:03:39 UTC
cockpit-212-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-f951136bb9

Comment 18 Fedora Update System 2020-02-15 02:54:08 UTC
cockpit-212-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.