Bug 1792707

Summary: xlators/features/quota/src/quota.c:quota_log_usage
Product: [Community] GlusterFS Reporter: JinyuXi <xijinyu0811>
Component: quotaAssignee: bugs <bugs>
Status: CLOSED CURRENTRELEASE QA Contact:
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, pasik, sunkumar
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1791154 Environment:
Last Closed: 2020-01-27 09:06:39 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description JinyuXi 2020-01-19 09:28:53 UTC 
+++ This bug was initially created as a clone of Bug #1791154 +++

//The quota_log_helper() function applies memory for path through inode_path(), no free.



if (DID_REACH_LIMIT(ctx->soft_lim, ctx->size, cur_size)) {
        quota_log_helper(&usage_str, cur_size, inode, &path, &cur_time);  
        gf_msg(this->name, GF_LOG_ALERT, 0, Q_MSG_CROSSED_SOFT_LIMIT,
               "Usage crossed soft limit: "
               "%s used by %s",
               usage_str, path);

        gf_event(EVENT_QUOTA_CROSSED_SOFT_LIMIT,
                 "Usage=%s;volume=%s;"
                 "path=%s",
                 usage_str, priv->volume_uuid, path);

        ctx->prev_log = cur_time;

    }

--- Additional comment from Worker Ant on 2020-01-15 03:23:33 UTC ---

REVIEW: https://review.gluster.org/24018 (Fix possible resource leaks.) posted (#1) for review on master by xijinyu
Comment 1 Worker Ant 2020-01-27 09:03:40 UTC 
REVIEW: https://review.gluster.org/24067 (Fix possible resource leaks.) posted (#1) for review on release-7 by Sunny Kumar
Comment 2 Worker Ant 2020-01-27 09:06:14 UTC 
REVISION POSTED: https://review.gluster.org/24067 (Fix possible resource leaks.) posted (#2) for review on release-7 by Sunny Kumar
Comment 3 Sunny Kumar 2020-01-27 09:06:39 UTC 
This issue has been addressed by:
https://review.gluster.org/#/c/glusterfs/+/24018/.

And patch is merged upstream.