Bug 1792814
| Summary: | xattr on target image not cleaned when blockcommit finished | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux Advanced Virtualization | Reporter: | yisun |
| Component: | libvirt | Assignee: | Michal Privoznik <mprivozn> |
| Status: | CLOSED ERRATA | QA Contact: | yisun |
| Severity: | high | Docs Contact: | |
| Priority: | high | ||
| Version: | 8.2 | CC: | dzheng, hhan, jdenemar, lmen, xuzhang, yafu, yisun |
| Target Milestone: | rc | Keywords: | Automation, Regression |
| Target Release: | 8.0 | Flags: | pm-rhel:
mirror+
|
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-6.6.0-8.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2021-02-22 15:39:38 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
yisun
2020-01-20 03:53:04 UTC
behaviour changed a little in latest rhelav build: libvirt-6.6.0-8.module+el8.3.1+8648+130818f2.x86_64 qemu-kvm-5.1.0-13.module+el8.3.0+8424+e82f331d.x86_64 [root@dell-per730-62 ~]# virsh snapshot-create-as vm1 s1 --disk-only Domain snapshot s1 created [root@dell-per730-62 ~]# virsh snapshot-create-as vm1 s2 --disk-only Domain snapshot s2 created [root@dell-per730-62 ~]# fvirsh blockcommit vm1 vda --top /var/lib/libvirt/images/jeos-27-x86_64.s1 --base /var/lib/libvirt/images/jeos-27-x86_64.qcow2 -bash: fvirsh: command not found [root@dell-per730-62 ~]# getenforce Enforcing [root@dell-per730-62 ~]# virsh blockcommit vm1 vda --top /var/lib/libvirt/images/jeos-27-x86_64.s1 --base /var/lib/libvirt/images/jeos-27-x86_64.qcow2 Block Commit started [root@dell-per730-62 ~]# virsh blockjob vm1 vda No current block job for vda [root@dell-per730-62 ~]# virsh snapshot-create-as vm1 s3 --disk-only Domain snapshot s3 created [root@dell-per730-62 ~]# virsh blockcommit vm1 vda --top /var/lib/libvirt/images/jeos-27-x86_64.s3 --base /var/lib/libvirt/images/jeos-27-x86_64.qcow2 --pivot Successfully pivoted <======= not failed here [root@dell-per730-62 ~]# getfattr -n trusted.libvirt.security.ref_selinux /var/lib/libvirt/images/jeos-27-x86_64.qcow2 getfattr: Removing leading '/' from absolute path names # file: var/lib/libvirt/images/jeos-27-x86_64.qcow2 trusted.libvirt.security.ref_selinux="1" (In reply to yisun from comment #3) > behaviour changed a little in latest rhelav build: > libvirt-6.6.0-8.module+el8.3.1+8648+130818f2.x86_64 > qemu-kvm-5.1.0-13.module+el8.3.0+8424+e82f331d.x86_64 > > [root@dell-per730-62 ~]# virsh blockcommit vm1 vda --top > /var/lib/libvirt/images/jeos-27-x86_64.s3 --base > /var/lib/libvirt/images/jeos-27-x86_64.qcow2 --pivot > Successfully pivoted > <======= not failed here > [root@dell-per730-62 ~]# getfattr -n trusted.libvirt.security.ref_selinux > /var/lib/libvirt/images/jeos-27-x86_64.qcow2 > getfattr: Removing leading '/' from absolute path names > # file: var/lib/libvirt/images/jeos-27-x86_64.qcow2 > trusted.libvirt.security.ref_selinux="1" Isn't this expected? The disk was pivoted back to /var/lib/libvirt/images/jeos-27-x86_64.qcow2 and thus the file was relabeled and is in use (one time exactly). I think, what you'll find is that 'virsh domblklist vm1' will print: Target Source ------------------------------------------------- vda /var/lib/libvirt/images/jeos-27-x86_64.qcow2 In my opinion, this is fixed. (In reply to Michal Privoznik from comment #4) > (In reply to yisun from comment #3) > > behaviour changed a little in latest rhelav build: > > libvirt-6.6.0-8.module+el8.3.1+8648+130818f2.x86_64 > > qemu-kvm-5.1.0-13.module+el8.3.0+8424+e82f331d.x86_64 > > > > > [root@dell-per730-62 ~]# virsh blockcommit vm1 vda --top > > /var/lib/libvirt/images/jeos-27-x86_64.s3 --base > > /var/lib/libvirt/images/jeos-27-x86_64.qcow2 --pivot > > Successfully pivoted > > <======= not failed here > > [root@dell-per730-62 ~]# getfattr -n trusted.libvirt.security.ref_selinux > > /var/lib/libvirt/images/jeos-27-x86_64.qcow2 > > getfattr: Removing leading '/' from absolute path names > > # file: var/lib/libvirt/images/jeos-27-x86_64.qcow2 > > trusted.libvirt.security.ref_selinux="1" > > Isn't this expected? The disk was pivoted back to > /var/lib/libvirt/images/jeos-27-x86_64.qcow2 and thus the file was relabeled > and is in use (one time exactly). I think, what you'll find is that 'virsh > domblklist vm1' will print: > > Target Source > ------------------------------------------------- > vda /var/lib/libvirt/images/jeos-27-x86_64.qcow2 > > > In my opinion, this is fixed. hmm, yes, it's fixed. I'll directly set this to verified. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (virt:8.3 bug fix and enhancement update), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2021:0639 |