Bug 1793011
| Summary: | python-pysrt fails to build with Python 3.9: invalid open() mode U | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> |
| Component: | python-pysrt | Assignee: | Juan Orti <jorti> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | cstratak, jorti, mhroncok, vstinner |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-01-22 13:04:48 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1785415 | ||
I proposed a fix upstream: https://github.com/byroot/pysrt/pull/80 > I proposed a fix upstream: https://github.com/byroot/pysrt/pull/80 Oh wow, it has been merged in 30 seconds!!! https://github.com/byroot/pysrt/commit/5465f2fd26f254af60cebad9cd0d4986a915347b Take that, unresponsive maintainers :-D > https://github.com/byroot/pysrt/commit/5465f2fd26f254af60cebad9cd0d4986a915347b
pysrt 1.1.2 is out with my fix.
Thanks! Already built for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=40865859 Great, that was quick! |
python-pysrt fails to build with Python 3.9.0a2. Traceback (most recent call last): File "/builddir/build/BUILD/pysrt-1.1.1/tests/test_srtfile.py", line 80, in test_compare_from_string_and_from_path iterator = zip(pysrt.open(self.utf8_path), File "/builddir/build/BUILD/pysrt-1.1.1/pysrt/srtfile.py", line 151, in open source_file, encoding = cls._open_unicode_file(path, claimed_encoding=encoding) File "/builddir/build/BUILD/pysrt-1.1.1/pysrt/srtfile.py", line 293, in _open_unicode_file source_file = codecs.open(path, 'rU', encoding=encoding) File "/usr/lib64/python3.9/codecs.py", line 905, in open file = builtins.open(filename, mode, buffering) ValueError: invalid mode: 'rUb' See https://docs.python.org/3.9/whatsnew/3.9.html#changes-in-the-python-api "open(), io.open(), codecs.open() and fileinput.FileInput no longer accept 'U' (“universal newline”) in the file mode. This flag was deprecated since Python 3.3. In Python 3, the “universal newline” is used by default when a file is open in text mode. The newline parameter of open() controls how universal newlines works." For the build logs, see: https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01162049-python-pysrt/ For all our attempts to build python-pysrt with Python 3.9, see: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-pysrt/ Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9: https://copr.fedorainfracloud.org/coprs/g/python/python3.9/ Let us know here if you have any questions. Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9. A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon. We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.