Bug 1793412

Summary: config ssh-port can accept negative and outside allowed port range value
Product: [Community] GlusterFS Reporter: Sunny Kumar <sunkumar>
Component: geo-replicationAssignee: Sunny Kumar <sunkumar>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: 7CC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1792276 Environment:
Last Closed: 2020-02-10 07:30:25 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1792276, 1796814    
Bug Blocks:    

Description Sunny Kumar 2020-01-21 10:09:52 UTC 
+++ This bug was initially created as a clone of Bug #1792276 +++

Description of problem:

If non-standard ssh-port is used, Geo-rep can be configured to use ssh port by using config option, the value should be in allowed port range and non negative.


Version-Release number of selected component (if applicable):


How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:


$ gluster volume geo-replication master 127.0.0.1::slave config ssh-port -22
    geo-replication config updated successfully
$ gluster volume geo-replication master 127.0.0.1::slave config ssh-port 22222222
    geo-replication config updated successfully

--- Additional comment from Worker Ant on 2020-01-17 13:14:06 UTC ---

REVIEW: https://review.gluster.org/24035 (geo-rep: Fix ssh-port validation) posted (#1) for review on master by Sunny Kumar

--- Additional comment from Worker Ant on 2020-01-19 06:32:07 UTC ---

REVIEW: https://review.gluster.org/24035 (geo-rep: Fix ssh-port validation) merged (#2) on master by Sunny Kumar
Comment 1 Worker Ant 2020-01-21 10:12:18 UTC 
REVIEW: https://review.gluster.org/24048 (geo-rep: Fix ssh-port validation) posted (#1) for review on release-7 by Sunny Kumar
Comment 2 Worker Ant 2020-02-10 07:30:25 UTC 
REVIEW: https://review.gluster.org/24048 (geo-rep: Fix ssh-port validation) merged (#2) on release-7 by Rinku Kothiya