Bug 1793521

Summary: slurm-19.05.5-1.fc32 FTBFS: /usr/bin/ld: .libs/select_cons_tres.o:(.bss+0xb0): multiple definition of `node_record_table_ptr'; .libs/job_test.o:(.bss+0x8): first defined here
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: slurmAssignee: Philip Kovacs <pkfed>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: pkfed
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
URL: https://koschei.fedoraproject.org/package/slurm?collection=f32
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-01-22 17:02:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1750908, 1792464    

Description Petr Pisar 2020-01-21 14:00:06 UTC
slurm-19.05.5-1.fc32 fails to build in F32:

libtool: link: gcc -shared  -fPIC -DPIC  .libs/dist_tasks.o .libs/job_test.o .libs/select_cons_tres.o   -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -O2 -g -fstack-protector-strong -grecord-gcc-switches -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -m64 -mtune=generic -pthread -Wl,-z -Wl,relro -Wl,--as-needed -Wl,-z -Wl,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -Wl,-z -Wl,lazy   -pthread -Wl,-soname -Wl,select_cons_tres.so -o .libs/select_cons_tres.so
/usr/bin/ld: .libs/select_cons_tres.o:(.bss+0xb0): multiple definition of `node_record_table_ptr'; .libs/job_test.o:(.bss+0x8): first defined here
/usr/bin/ld: .libs/select_cons_tres.o:(.bss+0x6a0): multiple definition of `slurmctld_config'; .libs/job_test.o:(.bss+0x20): first defined here
/usr/bin/ld: .libs/select_cons_tres.o:(.bss+0xa0): multiple definition of `job_list'; .libs/job_test.o:(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
make[5]: *** [Makefile:577: select_cons_tres.la] Error 1
make[5]: Leaving directory '/home/test/fedora/slurm/slurm-19.05.5/src/plugins/select/cons_tres'

A difference between passing and failing build root is at <https://koschei.fedoraproject.org/build/7736161>. This is probably triggered with an upgrade of gcc from 9.2.1-1.fc32.3 to 10.0.1-0.3.fc32.

Comment 1 Philip Kovacs 2020-01-22 17:02:03 UTC
It's the new gcc 10 default of -fno-common.  I pushed and tested a workaround fix to master (using -fcommon) and filed a bug upstream for them to add the needed externs in their headers.  Closing.