Bug 1793619

Summary:	Review Request: rust-conv - Number of conversion traits with more specific semantics than those provided by 'as' or 'From'/'Into'
Product:	[Fedora] Fedora	Reporter:	Randy Barlow <rbarlow>
Component:	Package Review	Assignee:	Robert-André Mauchin 🐧 <eclipseo>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	eclipseo, package-review
Target Milestone:	---	Flags:	eclipseo: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-conv-0.3.3-1.fc32	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-29 15:50:59 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Randy Barlow 2020-01-21 17:09:36 UTC

Spec URL: https://bowlofeggs.fedorapeople.org/rust-conv.spec
SRPM URL: https://bowlofeggs.fedorapeople.org/rust-conv-0.3.3-1.fc32.src.rpm
Description: Number of conversion traits with more specific semantics than those provided by 'as' or 'From'/'Into'
Fedora Account System Username: bowlofeggs

Comment 1 Robert-André Mauchin 🐧 2020-01-22 01:51:21 UTC

 - Apache 2.0 → ASL 2.0

 - You have MIT twice, remove "and MIT"

 - There is no static binary or library in this crate so specifying the result of cargo-license is not needed, only the MIT code is shipped with this package:

# Upstream license specification: MIT
# cargo-license was used to determine this set
License:        MIT and (Apache 2.0 or MIT) and ISC and MIT and (MIT or Unlicense)

 - Summary is too long: no  more than 80 characters

 - You must include the LICENSE file with %license in %files:

%files          devel
%license LICENSE
%doc README.md
%{cargo_registry}/%{crate}-%{version_no_tilde}/

 - Fix the line encoding of the readme:

rust-conv-devel.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/rust-conv-devel/README.md

Comment 2 Randy Barlow 2020-01-23 17:56:25 UTC

Hi Robert-André!

I think I have addressed your concerns. I uploaded the changed files to the same URL as before. Thanks for the review!

Comment 3 Robert-André Mauchin 🐧 2020-01-23 19:28:51 UTC

 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Tests are ok
 - Conforms to Packaging Guidelines

Package approved.

Comment 4 Gwyn Ciesla 2020-01-29 15:13:25 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-conv

Comment 5 Randy Barlow 2020-01-29 15:50:59 UTC

Thanks for the review!