Bug 1794093

Summary: python-SALib fails to build with Python 3.9: invalid open() mode U
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-SALibAssignee: Ankur Sinha (FranciscoD) <sanjay.ankur>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, mhroncok, neuro-sig, sanjay.ankur, tir.karthi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-SALib-1.3.8-2.fc33 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-03-16 21:26:47 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415    

Description Miro Hrončok 2020-01-22 16:03:46 UTC
python-SALib fails to build with Python 3.9.0a2.

    def read_param_file(filename, delimiter=None):
        """Unpacks a parameter file into a dictionary
    
        Reads a parameter file of format::
    
            Param1,0,1,Group1,dist1
            Param2,0,1,Group2,dist2
            Param3,0,1,Group3,dist3
    
        (Group and Dist columns are optional)
    
        Returns a dictionary containing:
            - names - the names of the parameters
            - bounds - a list of lists of lower and upper bounds
            - num_vars - a scalar indicating the number of variables
                         (the length of names)
            - groups - a list of group names (strings) for each variable
            - dists - a list of distributions for the problem,
                        None if not specified or all uniform
    
        Arguments
        ---------
        filename : str
            The path to the parameter file
        delimiter : str, default=None
            The delimiter used in the file to distinguish between columns
    
        """
        names = []
        bounds = []
        groups = []
        dists = []
        num_vars = 0
        fieldnames = ['name', 'lower_bound', 'upper_bound', 'group', 'dist']
    
>       with open(filename, 'rU') as csvfile:
E       ValueError: invalid mode: 'rU'

See https://docs.python.org/3.9/whatsnew/3.9.html#changes-in-the-python-api

"open(), io.open(), codecs.open() and fileinput.FileInput no longer accept 'U' (“universal newline”) in the file mode. This flag was deprecated since Python 3.3. In Python 3, the “universal newline” is used by default when a file is open in text mode. The newline parameter of open() controls how universal newlines works."



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01172933-python-SALib/

For all our attempts to build python-SALib with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-SALib/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-01-22 17:01:47 UTC
Seems to be fixed upstream with https://github.com/SALib/SALib/commit/2eb776b6c7ff0737e4d9855709e6e24c19e36971

Comment 2 Ben Cotton 2020-02-11 17:28:16 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 3 Miro Hrončok 2020-03-16 13:40:36 UTC
FranciscoD, could you please backport the fix or update if possible?