Bug 1794276

Summary:	python-pdir2 fails to build with Python 3.9: imports abc from collections
Product:	[Fedora] Fedora	Reporter:	Miro Hrončok <mhroncok>
Component:	python-pdir2	Assignee:	Carl George 🤠 <carl>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	carl, cstratak, mhroncok, python-sig, tir.karthi
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-23 23:24:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1785415

Description Miro Hrončok 2020-01-23 07:48:02 UTC

python-pdir2 fails to build with Python 3.9.0a2.

E   AttributeError: module 'collections' has no attribute 'Iterator'
pdir/attr_category.py:81: AttributeError

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The abstract base classes in collections.abc no longer are exposed in the regular collections module. This will help create a clearer distinction between the concrete classes and the abstract base classes."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01173167-python-pdir2/

For all our attempts to build python-pdir2 with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/python-pdir2/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-01-23 08:05:56 UTC

Seems to be fixed with https://github.com/laike9m/pdir2/commit/5d44803dca3c24eba44aac373a8e06ebacea59a5. Thanks

Comment 2 Carl George 🤠 2020-01-23 23:24:11 UTC

Thanks for isolating the fix Karthikeyan.  I had to tweak it slightly but it's in the package now.

https://src.fedoraproject.org/rpms/python-pdir2/c/0201e3d987e63b15b072c3af9604604f51b3a397?branch=master
https://bodhi.fedoraproject.org/updates/FEDORA-2020-57ee2ade29