Bug 1794564
| Summary: | Review Request: babeltrace2 - A trace manipulation toolkit | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michael Jeanson <mjeanson> |
| Component: | Package Review | Assignee: | Hirotaka Wakabayashi <hiwkby> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | hiwkby, package-review |
| Target Milestone: | --- | Flags: | hiwkby:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-02-10 18:50:03 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Michael Jeanson
2020-01-23 20:09:02 UTC
Hello Michael, Please see the comments. 1. Architecture s390x should be listed in the spec in ExcludeArch if this package doesn't support the s390x architecture. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_architecture_build_failures I found a build error on s390x architecture in a Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=41310129 2. python3-bt2's description python3-bt2 package should have a descrption. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_summary_and_description 3. License The base package, which is "babeltrace2" in this case, should include the upstream license file. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_spec_file_naming This package should contain a comment explaining the multiple licensing breakdown. Please see: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios Best Regards, Hirotaka Wakabayashi Hi, I've uploaded a new version of the package addressing your comments: Spec URL: https://mjeanson.fedorapeople.org/babeltrace2/babeltrace2.spec SRPM URL: https://mjeanson.fedorapeople.org/babeltrace2/babeltrace2-2.0.0-2.fc32.src.rpm Here is the corresponding koji scratch build : https://koji.fedoraproject.org/koji/taskinfo?taskID=41368542 It now successfully builds on all architectures. Regards, Michael Hello, Michael Package approved. Thanks you for your work. I'm sorry for my late response. Attached is a copy of rpmlint in my local environment. Regards, Hirotaka Wakabayashi ``` # rpmlint ~/rpmbuild/SRPMS/babeltrace2-2.0.0-2.fc31.src.rpm babeltrace2.src: W: spelling-error %description -l en_US Babeltrace -> Babel trace, Babel-trace, Traceable babeltrace2.src: W: spelling-error %description -l en_US barectf -> barefoot babeltrace2.src:76: W: mixed-use-of-spaces-and-tabs (spaces: line 1, tab: line 76) # rpmlint ~/rpmbuild/RPMS/x86_64/babeltrace2-2.0.0-2.fc31.x86_64.rpm babeltrace2.x86_64: W: spelling-error %description -l en_US Babeltrace -> Babel trace, Babel-trace, Traceable babeltrace2.x86_64: W: spelling-error %description -l en_US barectf -> barefoot 1 packages and 0 specfiles checked; 0 errors, 2 warnings. # rpmlint ~/rpmbuild/RPMS/x86_64/libbabeltrace2-devel-2.0.0-2.fc31.x86_64.rpm libbabeltrace2-devel.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # rpmlint ~/rpmbuild/RPMS/x86_64/libbabeltrace2-2.0.0-2.fc31.x86_64.rpm libbabeltrace2.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. # rpmlint ~/rpmbuild/RPMS/x86_64/python3-bt2-2.0.0-2.fc31.x86_64.rpm python3-bt2.x86_64: W: summary-not-capitalized C libbabeltrace2 python bindings python3-bt2.x86_64: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 2 warnings. ``` (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/babeltrace2 Thanks! |