Bug 1794625

Summary:	h5cc shouldn't use Fedora build flags
Product:	[Fedora] Fedora	Reporter:	Christoph Junghans <junghans>
Component:	hdf5	Assignee:	Orion Poplawski <orion>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	anto.trande, c.david86, dakingun, igor.raits, orion
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	hdf5-1.10.5-5.fc32 hdf5-1.10.5-5.fc31	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-01-27 02:36:29 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Christoph Junghans 2020-01-24 04:44:46 UTC

Description of problem:

h5cc includes "-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1" in its flags, which is provided by redhat-rpm-config, but isn't installed when install hdf5-devel.

Version-Release number of selected component (if applicable):

hdf5-1.10.5-3.fc32

How reproducible:

Compile anything with h5cc without having redhat-rpm-config installed.

Comment 1 Orion Poplawski 2020-01-27 01:01:34 UTC

Actually, I think h5cc shouldn't be specifying any special Fedora build flags that are not absolutely needed.  Taking a look...

Comment 2 Orion Poplawski 2020-01-27 02:20:02 UTC

Hopefully fixed in hdf5-1.10.5-5.fc32.  Let me know if you have any issues with that.

Comment 3 Christoph Junghans 2020-01-27 02:27:26 UTC

Thanks, looks good to me.

Just out of curiosity, why didn't you overwrite CPPFLAGS as well? (see https://src.fedoraproject.org/rpms/hdf5/blob/6a442e16217e3eee5ecd670a57297c73cd81cdc5/f/hdf5-wrappers.patch#_83)

Comment 4 Orion Poplawski 2020-01-27 02:36:29 UTC

It's not set to anything at the moment, and not sure it it might be needed in the future.

Comment 5 Fedora Update System 2020-01-31 01:29:07 UTC

hdf5-1.10.5-5.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-1e7bcc29a8

Comment 6 Fedora Update System 2020-02-08 02:00:11 UTC

hdf5-1.10.5-5.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.