Bug 1794780

New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/d44320707dfeb57582cbc814d91d7fc68cdd42b2
commit d44320707dfeb57582cbc814d91d7fc68cdd42b2
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Thu Dec 12 03:02:04 2019 -0500
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Thu Dec 12 03:02:04 2019 -0500

    Merge pull request #6530 from martinpovolny/ansible_automate_methods_more

    Automate Ansible: host+input params for playbooks, input params for workflows

    (cherry picked from commit 992c497d55883aeed4b6eb6ff7971a9549356580)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1794780

 app/views/layouts/angular/_ansible_form_options_angular.html.haml | 4 +-
 app/views/miq_ae_class/_angular_inputs_form.html.haml | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Hi,

Tested on version: 5.11.2.1.20200124195935_3ed31dc

Scenarios:
==========

1] For Ansible Tower Job Template: 

1a. Created method with 'Input Parameters', 'provider', 'Hosts' and other values. Saved this method.
1b. On details page, 'provider' and 'Hosts' are missing.
1c. Tried editing this method. While editing, Input Parameters lost and provider too. 
1d. If we give name to 'Input Parameters' like '@123', '@@@' or any name which contains special chars. Then while saving the method, it gives this error: "Error during 'save': Failed to replace inputs because one or more of the new records could not be saved.". This error does not tell what actually is problem. [See screenshot 1]

2] For Ansible Tower Workflow Template:

2a. Created method with 'Input Parameters' and 'provider' and other values. Saved this method.
2b. On details page provider is not available.
2c. Tried editing this method. While editing, Input Parameters lost and provider too. 
2d. If we give name to 'Input Parameters' like '@123', '@@@' or any name which contains special chars. Then it gives error: "Error during 'save': Failed to replace inputs because one or more of the new records could not be saved." [See screenshot 2]

And if 1d and 2d performed while creating method then it gives this error: "Error during 'save': Validation failed: MiqAeMethod: Name may contain only alphanumeric and _ characters". [See screenshot 3]

Hence failing this BZ.

Thanks,
Ganesh

The "provider" field is used as a step toward filling in the "Job Template" field. Only the Job Template is actually saved. Therefor it's not displayed and does not load.

I do not consider this a bug.

Looking at the other issues.

WIP PR: https://github.com/ManageIQ/manageiq-ui-classic/pull/6688

On the 1d) and 2b) this has not changed in this issue. The behavior is the consistent with other types of method.

To properly address that issue the forms needs to be completely rewritten from the RJS/Angular combination to use React and the API. That is not in scope here.

To sum up:

 * I am fixing part the loading of input parameters in the form when editing. This is a real issue.
 * I am also adding the Hosts to the display of the method.

The rest I do not consider a bug or related to this issue and the behavior is not new.

New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk:

https://github.com/ManageIQ/manageiq-ui-classic/commit/e541c436e284c38a237bd4d32bc74d30cfd27aee
commit e541c436e284c38a237bd4d32bc74d30cfd27aee
Author:     Milan Zázrivec <mzazrivec>
AuthorDate: Wed Feb 19 16:01:24 2020 +0000
Commit:     Milan Zázrivec <mzazrivec>
CommitDate: Wed Feb 19 16:01:24 2020 +0000

    Merge pull request #6688 from martinpovolny/more_a_methods

    Load inputs for Ansible* methods.

    (cherry picked from commit 9c9e879dea4fbdd34b87053f951e701db57f0d4a)

    https://bugzilla.redhat.com/show_bug.cgi?id=1794780

 app/controllers/miq_ae_class_controller.rb | 28 +-
 app/views/miq_ae_class/_method_inputs.html.haml | 2 +-
 2 files changed, 16 insertions(+), 14 deletions(-)

Verified this BZ as per "Martin Povolny" comment.
Verified with build 5.11.5.1

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2020