Bug 1795068
| Summary: | Review Request: python-diskcache - Disk and file backed persistent cache | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabian Affolter <mail> |
| Component: | Package Review | Assignee: | Fabio Valentini <decathorpe> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | decathorpe, package-review |
| Target Milestone: | --- | Flags: | decathorpe:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-03-27 08:00:41 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Fabian Affolter
2020-01-26 21:16:27 UTC
I can review this package.
Initial comments / suggestions / recommendations:
1) It looks like you're using pypi source tarball. You should be able to just use "%{pypi_source}" for that.
2) You could deduplicate the %descriptions (like I commented on python-shodan).
3) Please use trailing slashes for directories in %files:
%{python3_sitelib}/%{pypi_name}/
%{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/
Other than that, looks good.
Let me know when the package is ready for the formal review.
Thanks for your help. (In reply to Fabio Valentini from comment #1) > 1) It looks like you're using pypi source tarball. You should be able to > just use "%{pypi_source}" for that. Fixed > 2) You could deduplicate the %descriptions (like I commented on > python-shodan). I would like to keep it simple. > 3) Please use trailing slashes for directories in %files: > > %{python3_sitelib}/%{pypi_name}/ > %{python3_sitelib}/%{pypi_name}-%{version}-py%{python3_version}.egg-info/ Fixed Updated files: Spec URL: https://fab.fedorapeople.org/packages/SRPMS/python-diskcache.spec SRPM URL: https://fab.fedorapeople.org/packages/SRPMS/python-diskcache-4.1.0-2.fc31.src.rpm Looks good now. Thanks! Package approved. Thanks for your support. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-diskcache FEDORA-2020-ac573bf385 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-ac573bf385 python-diskcache-4.1.0-2.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-ac573bf385 python-diskcache-4.1.0-2.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-d79460fdf7 python-diskcache-4.1.0-2.fc31 has been pushed to the Fedora 31 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a1370763de FEDORA-2020-ac573bf385 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-d79460fdf7 has been pushed to the Fedora 30 stable repository. If problem still persists, please make note of it in this bug report. FEDORA-2020-a1370763de has been pushed to the Fedora 31 stable repository. If problem still persists, please make note of it in this bug report. |