Bug 1795581

Summary: VDSM does not allow bond interface with a dash in the name
Product: [oVirt] ovirt-hosted-engine-setup Reporter: Asaf Rachmani <arachman>
Component: NetworkAssignee: Evgeny Slutsky <eslutsky>
Status: CLOSED NOTABUG QA Contact: Michael Burman <mburman>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 2.3.12CC: bugs, dholler, stirabos
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-02-18 09:04:39 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Integration RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1776302    
Attachments:
Description Flags
hosted-engine-logs none

Description Asaf Rachmani 2020-01-28 11:28:50 UTC 
Created attachment 1655993 [details]
hosted-engine-logs

Description of problem:
VDSM does not allow bond interface with a dash in the name

Version-Release number of selected component (if applicable):
ovirt-hosted-engine-setup-2.3.12-1.el7.noarch
vdsm-4.30.38-1.el7.x86_64
vdsm-network-4.30.38-1.el7.x86_64
ovirt-release-host-node-4.3.7-1.el7.noarch

How reproducible: 
100%

Steps to Reproduce:
1. Use the following PR https://github.com/oVirt/ovirt-ansible-hosted-engine-setup/pull/284
2. Run hosted-engine --deploy


Actual results:
Deployment fails:
2020-01-27 15:53:23,807+0000 INFO otopi.ovirt_hosted_engine_setup.ansible_utils ansible_utils._process_output:109 ok: [localhost]
2020-01-27 15:53:24,208+0000 INFO otopi.ovirt_hosted_engine_setup.ansible_utils ansible_utils._process_output:109 TASK [ovirt.hosted_engine_setup : Fail with error description]
2020-01-27 15:53:24,610+0000 DEBUG otopi.ovirt_hosted_engine_setup.ansible_utils ansible_utils._process_output:103 {u'msg': u'The host has been set in non_operational status, deployment errors:   code 505: Host node1.asrachmani.com instal
lation failed. Failed to configure management network on the host.,    code 1120: Failed to configure management network on host node1.asrachmani.com due to setup networks failure.,    code 9000: Failed to verify Power Management configur
ation for Host node1.asrachmani.com.,    code 10802: VDSM node1.asrachmani.com command HostSetupNetworksVDS failed: bad bond name(s): bond-0,   fix accordingly and re-deploy.', u'changed': False, u'_ansible_no_log': False}
2020-01-27 15:53:24,710+0000 ERROR otopi.ovirt_hosted_engine_setup.ansible_utils ansible_utils._process_output:107 fatal: [localhost]: FAILED! => {"changed": false, "msg": "The host has been set in non_operational status, deployment errors:   code 505: Host node1.asrachmani.com installation failed. Failed to configure management network on the host.,    code 1120: Failed to configure management network on host node1.asrachmani.com due to setup networks failure.,    code 9000: Failed to verify Power Management configuration for Host node1.asrachmani.com.,    code 10802: VDSM node1.asrachmani.com command HostSetupNetworksVDS failed: bad bond name(s): bond-0,   fix accordingly and re-deploy."}
2020-01-27 15:53:25,011+0000 INFO otopi.ovirt_hosted_engine_setup.ansible_utils ansible_utils._process_output:109 TASK [ovirt.hosted_engine_setup : Fetch logs from the engine VM]
2020-01-27 15:53:25,513+0000 INFO otopi.ovirt_hosted_engine_setup.ansible_utils ansible_utils._process_output:109 ok: [localhost]


Expected results: 
Successful deployment


Additional info:
Related discussion in https://bugzilla.redhat.com/show_bug.cgi?id=1459229
Comment 2 Dominik Holler 2020-01-28 12:30:50 UTC 
Is there a way for hosted engine setup to reject invalid interface names for the management network?
Comment 3 Asaf Rachmani 2020-01-28 14:57:38 UTC 
Hosted engine rejects it, but it shouldn't [1].
Why this is an invalid interface name? if the os allows it we also should.
There are many scenarios to use bond interface names that do not match bondXYZ conventions, some of them described here [2]

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1776302
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1459229#c7
Comment 4 Dominik Holler 2020-01-28 15:07:21 UTC 
(In reply to Asaf Rachmani from comment #3)
> Hosted engine rejects it, but it shouldn't [1].

It should, because oVirt requires that the rules mentioned in comment #1 are respected.

> Why this is an invalid interface name? if the os allows it we also should.

No, oVirt has restrictions on the names.
If oVirt Engine allows you to create a bond, it should work.


> There are many scenarios to use bond interface names that do not match
> bondXYZ conventions, some of them described here [2]
> 
> [1] https://bugzilla.redhat.com/show_bug.cgi?id=1776302
> [2] https://bugzilla.redhat.com/show_bug.cgi?id=1459229#c7
Comment 6 Asaf Rachmani 2020-02-18 09:04:39 UTC 
Close it as NOTABUG as this is an oVirt restriction.