Bug 1795840

Summary:	Review Request: rust-float-ord - Total ordering for floating-point numbers
Product:	[Fedora] Fedora	Reporter:	Randy Barlow <rbarlow>
Component:	Package Review	Assignee:	Fabio Valentini <decathorpe>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	decathorpe, package-review, randy
Target Milestone:	---	Flags:	decathorpe: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	rust-float-ord-0.2.0-1.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-02-11 21:58:55 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Randy Barlow 2020-01-29 01:49:43 UTC

Spec URL: https://bowlofeggs.fedorapeople.org/rust-float-ord.spec
SRPM URL: https://bowlofeggs.fedorapeople.org/rust-float-ord-0.2.0-1.fc32.src.rpm
Description: Total ordering for floating-point numbers.
Fedora Account System Username: bowlofeggs

Comment 1 Fabio Valentini 2020-02-10 23:11:39 UTC

- latest version is packaged
- License correct
- Package builds in rawhide
- Built packages install in rawhide
- standard rust package

- only one issue I see:
Can you provide a link to an upstream change or a pending PR for the patch to port to rand 0.7?

Comment 2 Randy Barlow 2020-02-11 18:11:06 UTC

Hi Fabio!

I've added a link to the spec in a comment right above the Patch0 statement - the patch is merged upstream.

Comment 3 Fabio Valentini 2020-02-11 18:53:26 UTC

Perfect! Thanks.

Do you have a few minutes to review one of my pending rust packages in return?

Comment 4 Randy Barlow 2020-02-11 20:12:28 UTC

Hi Fabio, absolutely - I'll look at them right now.

Also, here's the repo request ticket:

https://pagure.io/releng/fedora-scm-requests/issue/22087

Comment 5 Randy Barlow 2020-02-11 21:01:20 UTC

Hi Fabio!

I just yesterday switched my Fedora account to use my personal bugzilla rather than my Red Hat one. As a result, I am now unable to import this package as you can see if you visit https://pagure.io/releng/fedora-scm-requests/issue/22087.

To fix that, I've filed https://bugzilla.redhat.com/show_bug.cgi?id=1801897 with the same spec/srpm. Would you mind marking it approved over there?

Comment 6 Fabio Valentini 2020-02-11 21:26:37 UTC

No problem.

Comment 7 Randy Barlow 2020-02-11 21:57:42 UTC

rust-float-ord-0.2.0-1.fc33 is built. Thanks!