Bug 1795858

Summary:	systemctl start crio failed
Product:	[Fedora] Fedora	Reporter:	lnie <lnie>
Component:	cri-o	Assignee:	Lokesh Mandvekar <lsm5>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	31	CC:	amurdaca, dougsland, dwalsh, fkluknav, gabibbo97, lsm5, pehunt, santiago
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cri-o-1.17-3120200320184841.f636be4b cri-o-1.17-3220200320184841.43bbeeef cri-o-1.17-3020200320184841.a5b0195c	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-25 09:49:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description lnie 2020-01-29 03:12:13 UTC

Description of problem:
systemctl start crio failed with:
invalid hooks_dir: stat /usr/share/containers/oci/hooks.d: no such file or directory
FYI:
You have to install oci-register-machine to have  crio started successfully

Version-Release number of selected component (if applicable):
cri-o-1.17.0-0.1.gitb89a5fc.module_f31+7363+0a59a30e.x86_64.rpm

How reproducible:
always

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Daniel Walsh 2020-01-29 03:50:48 UTC

There are two bugs here.
1. the package should install /usr/share/containers/oci/hooks.d by default.
2. CRI-O should run fine without the hooks.d directory.

Comment 2 lnie 2020-02-01 10:07:26 UTC

I tried with upstream version v1.17.0-rc1,the hooks_dir will be there after I run make install.config,so it seems to be a fedora-specific issue.

Comment 3 lnie 2020-02-23 11:56:01 UTC

forgot to mention,I have reported the issue on upstream,and it fixed in the commit
https://github.com/cri-o/cri-o/pull/3203/commits/0eec454168e381e460b3d6de07bf50bfd9b0d082

Comment 4 Lokesh Mandvekar 2020-03-15 15:38:39 UTC

Peter, can we get a new crio 1.17 tag pushed upstream to fix this?

Comment 5 Peter Hunt 2020-03-16 14:09:27 UTC

https://github.com/cri-o/cri-o/releases/tag/v1.17.1 is ready

Comment 6 Lokesh Mandvekar 2020-03-16 14:19:09 UTC

building at https://gitlab.com/rhcontainerbot/pkg-builder/-/jobs/473253138

Comment 7 Fedora Update System 2020-03-17 19:36:31 UTC

FEDORA-MODULAR-2020-ba936d9e88 has been submitted as an update to Fedora 31 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2020-ba936d9e88

Comment 8 lnie 2020-03-18 03:25:42 UTC

Hi,still failed... the fix code is in file pkg/config/config.go,which doesn't exit in your package.
I checked /usr/share/fish/completions/crio.fish from your package,there is no "If one of the directories does not exist, then CRI-O will automatically skip them" 
which is part of that commit,so I guess I can safely say, that commit isn't picked.

Comment 9 Fedora Update System 2020-03-18 05:09:53 UTC

cri-o-1.17-3120200316141245.f636be4b has been pushed to the Fedora 31 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2020-ba936d9e88

Comment 10 Fedora Update System 2020-03-21 00:14:14 UTC

FEDORA-MODULAR-2020-a1852c8ad2 has been submitted as an update to Fedora 30 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2020-a1852c8ad2

Comment 11 Fedora Update System 2020-03-21 00:14:15 UTC

FEDORA-MODULAR-2020-6f8581d8ed has been submitted as an update to Fedora 32 Modular. https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2020-6f8581d8ed

Comment 12 lnie 2020-03-21 07:24:03 UTC

Works on f30,because cri-o has created /usr/share/containers/oci/hooks.d.
If you choose to fix this bug by installing /usr/share/containers/oci/hooks.d by default,would you please do the same to f31?Thanks!

Comment 13 Fedora Update System 2020-03-22 03:38:59 UTC

cri-o-1.17-3020200320184841.a5b0195c has been pushed to the Fedora 30 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2020-a1852c8ad2

Comment 14 Fedora Update System 2020-03-22 03:42:46 UTC

cri-o-1.17-3120200320184841.f636be4b has been pushed to the Fedora 31 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2020-91a9fc6b9a

Comment 15 Fedora Update System 2020-03-22 03:57:25 UTC

cri-o-1.17-3220200320184841.43bbeeef has been pushed to the Fedora 32 Modular testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-MODULAR-2020-6f8581d8ed

Comment 16 Fedora Update System 2020-03-25 09:49:22 UTC

FEDORA-MODULAR-2020-91a9fc6b9a has been pushed to the Fedora 31 Modular stable repository.
If problem still persists, please make note of it in this bug report.

Comment 17 Fedora Update System 2020-03-30 01:49:57 UTC

FEDORA-MODULAR-2020-6f8581d8ed has been pushed to the Fedora 32 Modular stable repository.
If problem still persists, please make note of it in this bug report.

Comment 18 Fedora Update System 2020-03-30 02:17:17 UTC

FEDORA-MODULAR-2020-a1852c8ad2 has been pushed to the Fedora 30 Modular stable repository.
If problem still persists, please make note of it in this bug report.