Bug 1795889

Vatsal is working on a fix in https://github.com/kubevirt/kubevirt/pull/3063

Since this is not a blocker and will likely need some additional work on API as discussed on the community call, I'm targeting this to 2.4.

Test Environment :
==================

$ oc version
Client Version: 4.5.0-rc.1
Server Version: 4.5.0-rc.1
Kubernetes Version: v1.18.3+a637491

CNV Version
$ oc get csv -n openshift-cnv | awk ' { print $4 } ' | tail -n1
2.4.0

Steps:
=====

Bug Summary: Vmi with Masquerade and guest-agent shows on spec the internal IP instead of the virt-launcher Pods IP.
Fix: Vmi will show the same IP of the virt-launcher Pod.

1. Create Vm with Masquerade

$ oc create -f vm-fedora.yaml
$ virtctl start vm-fedora

2. start guest-agent on vmi

$ virtctl console vm-fedora
[fedora@vm-fedora ~]$ sudo yum install -y qemu-guest-agent
[fedora@vm-fedora ~]$ sudo systemctl start qemu-guest-agent
[fedora@vm-fedora ~]$ sudo systemctl enable qemu-guest-agent

3. see in vmi status:conditions: that AgentConnected

$ oc get vmi vm-fedora -o yaml
apiVersion: kubevirt.io/v1alpha3
kind: VirtualMachineInstance
metadata:
  annotations:
    kubevirt.io/latest-observed-api-version: v1alpha3
    kubevirt.io/storage-observed-api-version: v1alpha3
  creationTimestamp: "2020-06-09T01:45:52Z"
  finalizers:
  - foregroundDeleteVirtualMachine
  generateName: vm-fedora
  generation: 11
  labels:
    kubevirt-vm: vm-fedora
    kubevirt.io/nodeName: host-172-16-0-34
  managedFields:
  - apiVersion: kubevirt.io/v1alpha3
    fieldsType: FieldsV1
    fieldsV1:
      f:metadata:
        f:annotations:
          .: {}
          f:kubevirt.io/latest-observed-api-version: {}
          f:kubevirt.io/storage-observed-api-version: {}
        f:generateName: {}
        f:labels:
          .: {}
          f:kubevirt-vm: {}
          f:kubevirt.io/nodeName: {}
        f:ownerReferences: {}
      f:spec:
        .: {}
        f:domain:
          .: {}
          f:cpu:
            .: {}
            f:cores: {}
          f:devices:
            .: {}
            f:disks: {}
            f:interfaces: {}
            f:rng: {}
          f:firmware:
            .: {}
            f:uuid: {}
          f:machine:
            .: {}
            f:type: {}
          f:resources:
            .: {}
            f:requests:
              .: {}
              f:memory: {}
        f:networks: {}
        f:terminationGracePeriodSeconds: {}
        f:volumes: {}
      f:status:
        .: {}
        f:activePods:
          .: {}
          f:493851dd-eafb-4403-aed7-5f35cf9c7a60: {}
        f:guestOSInfo: {}
        f:nodeName: {}
        f:qosClass: {}
    manager: virt-controller
    operation: Update
    time: "2020-06-09T01:46:00Z"
  - apiVersion: kubevirt.io/v1alpha3
    fieldsType: FieldsV1
    fieldsV1:
      f:status:
        f:conditions: {}
        f:guestOSInfo:
          f:id: {}
          f:kernelRelease: {}
          f:kernelVersion: {}
          f:name: {}
          f:prettyName: {}
          f:version: {}
          f:versionId: {}
        f:interfaces: {}
        f:migrationMethod: {}
        f:phase: {}
    manager: virt-handler
    operation: Update
    time: "2020-06-09T01:58:12Z"
  name: vm-fedora
  namespace: default
  ownerReferences:
  - apiVersion: kubevirt.io/v1alpha3
    blockOwnerDeletion: true
    controller: true
    kind: VirtualMachine
    name: vm-fedora
    uid: 4b36bab9-8012-4715-9404-1e876549d9c9
  resourceVersion: "1571484"
  selfLink: /apis/kubevirt.io/v1alpha3/namespaces/default/virtualmachineinstances/vm-fedora
  uid: c9f0ac70-da18-4422-aaf0-ce357718f55c
spec:
  domain:
    cpu:
      cores: 1
    devices:
      disks:
      - disk:
          bus: virtio
        name: disk0
      - disk:
          bus: virtio
        name: cloudinitdisk
      interfaces:
      - masquerade: {}
        name: default
      rng: {}
    features:
      acpi:
        enabled: true
    firmware:
      uuid: c9dc132f-1bb1-5f88-9891-deed35a6d803
    machine:
      type: pc-q35-rhel8.2.0
    resources:
      requests:
        cpu: 100m
        memory: 2Gi
  networks:
  - name: default
    pod: {}
  terminationGracePeriodSeconds: 0
  volumes:
  - containerDisk:
      image: kubevirt/fedora-cloud-container-disk-demo:latest
      imagePullPolicy: Always
    name: disk0
  - cloudInitNoCloud:
      userData: |-
        #cloud-config
        password: fedora
        chpasswd: { expire: False }
    name: cloudinitdisk
status:
  activePods:
    493851dd-eafb-4403-aed7-5f35cf9c7a60: host-172-16-0-34
  conditions:
  - lastProbeTime: null
    lastTransitionTime: null
    status: "True"
    type: LiveMigratable
  - lastProbeTime: null
    lastTransitionTime: "2020-06-09T01:45:59Z"
    status: "True"
    type: Ready
  - lastProbeTime: "2020-06-09T01:58:12Z"
    lastTransitionTime: null
    status: "True"
    type: AgentConnected
  guestOSInfo:
    id: fedora
    kernelRelease: 5.6.6-300.fc32.x86_64
    kernelVersion: '#1 SMP Tue Apr 21 13:44:19 UTC 2020'
    name: Fedora
    prettyName: Fedora 32 (Cloud Edition)
    version: "32"
    versionId: "32"
  interfaces:
  - interfaceName: eth0
    ipAddress: 10.128.2.141
    mac: 02:00:00:42:f6:15
    name: default
  migrationMethod: BlockMigration
  nodeName: host-172-16-0-34
  phase: Running
  qosClass: Burstable

4. Verify that vmi IP is the same as virt-launcher pod IP.

$ oc get pod,vmi -o wide
NAME                                READY   STATUS    RESTARTS   AGE   IP             NODE               NOMINATED NODE   READINESS GATES
pod/virt-launcher-vm-fedora-4kgmx   2/2     Running   0          21m   10.128.2.141   host-172-16-0-34   <none>           <none>

NAME                                           AGE   PHASE     IP             NODENAME           LIVE-MIGRATABLE
virtualmachineinstance.kubevirt.io/vm-fedora   21m   Running   10.128.2.141   host-172-16-0-34   True

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:3194