Bug 1796045

Summary: 'ip xfrm policy help' does not correctly list protocols
Product: Red Hat Enterprise Linux 8 Reporter: Andrea Claudi <aclaudi>
Component: iprouteAssignee: Andrea Claudi <aclaudi>
Status: CLOSED ERRATA QA Contact: xmu
Severity: medium Docs Contact:
Priority: medium    
Version: 8.2CC: atragler, jiji, jmaxwell, xmu
Target Milestone: rc   
Target Release: 8.0   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: iproute-5.3.0-2.el8 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-04 01:43:46 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1807630    

Description Andrea Claudi 2020-01-29 13:36:25 UTC
Description of problem:
Case #1 from bz#1791544 also verifies on 'ip xfrm policy help' command:

How reproducible:
# ip xfrm policy help

Actual results:
UPSPEC := proto { { tcp | tcp | tcp | tcp } [ sport PORT ] [ dport PORT ] |
                  { icmp | icmp | icmp } [ type NUMBER ] [ code NUMBER ] |
                  gre [ key { DOTTED-QUAD | NUMBER } ] | PROTO }

Expected results:
UPSPEC := proto { { tcp | udp | sctp | dccp } [ sport PORT ] [ dport PORT ] |
                  { icmp | ipv6-icmp | mobility-header } [ type NUMBER ] [ code NUMBER ] |
                  gre [ key { DOTTED-QUAD | NUMBER } ] | PROTO }

Comment 1 Andrea Claudi 2020-01-29 15:01:20 UTC
Patch submitted upstream: https://patchwork.ozlabs.org/patch/1230947/

Comment 2 Andrea Claudi 2020-01-30 10:04:32 UTC
Patch accepted upstream:

commit 38dd041bfe773e481ebf9c8250e49c665af2e215
Author: Andrea Claudi <aclaudi>
Date:   Wed Jan 29 15:56:40 2020 +0100

    ip-xfrm: Fix help messages

Comment 10 errata-xmlrpc 2020-11-04 01:43:46 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (iproute bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:4478