Bug 1796245

Summary:	abrt-addon-ccpp causes failures during openscap scans on CCE-27119-7
Product:	Red Hat Enterprise Linux 7	Reporter:	Ryan Mullett <rmullett>
Component:	abrt	Assignee:	ekulik
Status:	CLOSED UPSTREAM	QA Contact:	BaseOS QE - Apps <qe-baseos-apps>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	7.7	CC:	ekulik, ggasparb, mhaicman, mkolbas, mkyral, mmarhefk, msuchy, openscap-maint, sgrubb
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1835388 (view as bug list)		Environment:
Last Closed:	2020-05-13 17:40:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1835388

Description Ryan Mullett 2020-01-30 00:02:18 UTC

Description of problem:
The CCE-27119-7 openscap rule requires that all system executables have root ownership. There is a binary file provided by abrt-addon-ccpp that violates this, and is owned by abrt:abrt instead of root:root

-rwsr-sr-x. 1 abrt abrt 15432 Mar 20  2019 /usr/libexec/abrt-action-install-debuginfo-to-abrt-cache

Version-Release number of selected component (if applicable):
abrt-addon-ccpp-2.1.11-55.el7.x86_64

How reproducible:
Always

Steps to Reproduce:
1. Install abrt-addon-ccpp
2. Utilize openscap to scan the system

Actual results:
- The /usr/libexec/abrt-action-install-debuginfo-to-abrt-cache is owned by abrt:abrt

Expected results:
- The /usr/libexec/abrt-action-install-debuginfo-to-abrt-cache file should be owned by root:root

Additional info:

Comment 3 ekulik 2020-02-07 12:37:10 UTC

You will notice that the binary is setuid, so having it just be owned by root:root would be even worse.

Comment 4 ekulik 2020-02-11 11:58:10 UTC

Since this cannot be solved without redesigning certain things, I’m reassigning to openscap to possibly whitelist the binary.

The specific owner and setuid bit are needed for this wrapper to run abrt-action-install-debuginfo as abrt to write to /var/cache/abrt-di, which is owned by abrt as well. setuid root would break the various tools that poke at the directory, unless we made everything setuid root.

Comment 6 Marek Haicman 2020-02-14 21:14:13 UTC

Moving to the right-er component than `openscap` (as the change would not be in the scanner, but in the content)

Also please take into consideration that ABRT is quite often removed by our profiles (as it can expose crash data). So it's more than possible that we will forbear to update one of the core rules just because of the needs of this particular package.

Comment 10 ekulik 2020-02-21 09:35:40 UTC

Given that it is unlikely that we will get an exception, I’m moving this back to abrt.

Comment 13 Miroslav Suchý 2020-05-06 17:17:12 UTC

Upstream Pull Requests:
https://github.com/abrt/libreport/pull/631
https://github.com/abrt/abrt/pull/1485

Comment 14 Miroslav Suchý 2020-05-13 17:40:57 UTC

The change has been incorporated to upstream. But the change is quite big. It changes the script from setuid to setgid and changes ownership of caches from abrt: to :abrt.
I cannot recommend it for backport to RHEL7 in its late-cycle as the current bug "just" emits warning in OpenSCAP, but the change we have done can have an impact on functionality.
I am going to close this, but we will backport it to RHEL8.