Bug 1796391

Summary: rebase-helper fails to build with Python 3.9: encoding parameter of json.loads() has been removed
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: rebase-helperAssignee: Petr Hracek <phracek>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, fnecas, mhroncok, nforro, phracek, thozza, tir.karthi
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: rebase-helper-0.20.0-3.fc32 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-02-03 11:21:27 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415    

Description Miro Hrončok 2020-01-30 10:32:25 UTC
rebase-helper fails to build with Python 3.9.0a3.

>           json_dict = json.load(f, encoding='utf-8')
...
E       TypeError: __init__() got an unexpected keyword argument 'encoding'

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The encoding parameter of json.loads() has been removed. As of Python 3.1, it was deprecated and ignored; using it has emitted a DeprecationWarning since Python 3.8."


For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01200281-rebase-helper/

For all our attempts to build rebase-helper with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/rebase-helper/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Karthikeyan Singaravelan 2020-01-30 19:37:19 UTC
Upstream PR : https://github.com/rebase-helper/rebase-helper/pull/771