Bug 1796537

Summary:	crio.service fails to start in RHCOS 4.4 with invalid hooks directory error
Product:	OpenShift Container Platform	Reporter:	Prashanth Sundararaman <psundara>
Component:	RHCOS	Assignee:	Micah Abbott <miabbott>
Status:	CLOSED ERRATA	QA Contact:	Michael Nguyen <mnguyen>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	4.4	CC:	bbreard, dustymabe, imcleod, jligon, nstielau, pehunt, smilner
Target Milestone:	---
Target Release:	4.4.0
Hardware:	All
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1796555 (view as bug list)		Environment:
Last Closed:	2020-05-13 21:55:50 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1796555

Description Prashanth Sundararaman 2020-01-30 16:37:33 UTC

Description of problem:

When running kola test - crio.base on the RHCOS version 4.4 - a private build - 44.81.202001301530.0, the test fails with:

Jan 30 15:37:49.224043 crio[1520]: time="2020-01-30 15:37:49.223914700Z" level=fatal msg="runtime config: invalid hooks_dir: stat /usr/share/containers/oci/hooks.d: no such file or directory: stat /usr/share/con
tainers/oci/hooks.d: no such file or directory"

Version-Release number of selected component (if applicable):

RHCOS - 4.4 


How reproducible:

All the time

Steps to Reproduce:
1.Get a 4.4 RHCOS build
2. Boot into it anyway you like (I used the qemu image and did a `cosa run`)
3. do a `sudo systemctl start crio`
4. check `systemctl status crio`

Actual results:

crio service fails to start with above error

Expected results:

crio service should start successfully

Additional info:

After conversations on slack with the CoreOS and crio-team, the short term fix is to pull in the oci-systemd-hook package which provides the missing directory.

Comment 6 Michael Nguyen 2020-02-19 19:54:30 UTC

Verified on RHCOS 44.81.202002022230

[core@localhost ~]$ ls -laRtZ /usr/share/containers/oci/
/usr/share/containers/oci/:
total 0
drwxr-xr-x. 3 root root system_u:object_r:usr_t:s0 21 Jan  1  1970 .
drwxr-xr-x. 3 root root system_u:object_r:usr_t:s0 75 Jan  1  1970 ..
drwxr-xr-x. 2 root root system_u:object_r:usr_t:s0  6 Jan  1  1970 hooks.d

/usr/share/containers/oci/hooks.d:
total 0
drwxr-xr-x. 2 root root system_u:object_r:usr_t:s0  6 Jan  1  1970 .
drwxr-xr-x. 3 root root system_u:object_r:usr_t:s0 21 Jan  1  1970 ..
[core@localhost ~]$ rpm-ostree status
State: idle
AutomaticUpdates: disabled
Deployments:
* ostree://d32c2fd11e114e2fb38c4f073e6abb92f9c576203ab49a0aee7817c61c903afe
                   Version: 44.81.202002022230-0 (2020-02-02T22:35:48Z)

Comment 7 Michael Nguyen 2020-02-19 19:55:53 UTC

Started crio successfully also.

[core@localhost ~]$ systemctl status crio
● crio.service - Open Container Initiative Daemon
   Loaded: loaded (/usr/lib/systemd/system/crio.service; disabled; vendor prese>
   Active: inactive (dead)
     Docs: https://github.com/cri-o/cri-o

[core@localhost ~]$ 
[core@localhost ~]$ sudo systemctl status crio
● crio.service - Open Container Initiative Daemon
   Loaded: loaded (/usr/lib/systemd/system/crio.service; disabled; vendor prese>
   Active: inactive (dead)
     Docs: https://github.com/cri-o/cri-o
[core@localhost ~]$ sudo systemctl start crio
[core@localhost ~]$ sudo systemctl status crio
● crio.service - Open Container Initiative Daemon
   Loaded: loaded (/usr/lib/systemd/system/crio.service; disabled; vendor prese>
   Active: active (running) since Wed 2020-02-19 19:54:55 UTC; 2s ago
     Docs: https://github.com/cri-o/cri-o
 Main PID: 1794 (crio)
    Tasks: 12
   Memory: 16.9M
   CGroup: /system.slice/crio.service
           └─1794 /usr/bin/crio --enable-metrics=true --metrics-port=9537

Feb 19 19:54:55 localhost systemd[1]: Starting Open Container Initiative Daemon>
Feb 19 19:54:55 localhost systemd[1]: Started Open Container Initiative Daemon.
[core@localhost ~]$ journalctl -r -b -u crio
-- Logs begin at Wed 2020-02-19 19:47:00 UTC, end at Wed 2020-02-19 19:55:01 UT>
Feb 19 19:54:55 localhost systemd[1]: Started Open Container Initiative Daemon.
Feb 19 19:54:55 localhost systemd[1]: Starting Open Container Initiative Daemon>

Comment 9 errata-xmlrpc 2020-05-13 21:55:50 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0581