Bug 1796796

Summary: [CNV-2.3 Deployment] cluster-network-addons-operator fails to create config map
Product: Container Native Virtualization (CNV) Reporter: Lukas Bednar <lbednar>
Component: NetworkingAssignee: Petr Horáček <phoracek>
Status: CLOSED ERRATA QA Contact: Lukas Bednar <lbednar>
Severity: urgent Docs Contact:
Priority: urgent    
Version: 2.3.0CC: cnv-qe-bugs, myakove, ncredi, pelauter, stirabos, ycui
Target Milestone: ---Keywords: TestBlocker
Target Release: 2.3.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: cluster-network-addons-operator-container-v2.3.0-11 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-05-04 19:10:37 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Lukas Bednar 2020-01-31 09:22:01 UTC
Description of problem:

When deploying CNV-2.3 on OCP-4.4, HCO is can not finish because underlying network operator is failing to create config map for network addions:

Degraded	True	NetworkAddonsConfig is degraded: could not apply (/v1, Kind=ConfigMap) openshift-cnv/cluster-networks-addons-operator-applied-cluster: could not create (/v1, Kind=ConfigMap) openshift-cnv/cluster-networks-addons-operator-applied-cluster: ConfigMap "cluster-networks-addons-operator-applied-cluster" is invalid: [metadata.labels: Invalid value: "sha256:7343c7089f04f1c7affab12fe9a6614f24ee62d84d0943b24c170a6e30fe374e": must be no more than 63 characters, metadata.labels: Invalid value: "sha256:7343c7089f04f1c7affab12fe9a6614f24ee62d84d0943b24c170a6e30fe374e": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')]


Version-Release number of selected component (if applicable):
OCP-4.4.0-0.nightly-2020-01-30-070618
CNV-2.3.0 from rh-verified-operators
cluster-network-addons-operator:
    Container ID:   cri-o://cd1c99a6ac4d4f22a40a7a822d0077fce4459722f5ad4429ff9a07bb3f2cedd2
    Image:          registry-proxy.engineering.redhat.com/rh-osbs/container-native-virtualization-cluster-network-addons-operator@sha256:7343c7089f04f1c7affab12fe9a6614f24ee62d84d0943b24c170a6e30fe374e



How reproducible: 100%


Steps to Reproduce:
1. Deploy CNV-2.3 on top of OCP-4.4
2. Observe status of network-addions operator
3.

Actual results: fails to get ready


Expected results: deployed CNV


Additional info:

Comment 1 Petr Horáček 2020-01-31 09:41:32 UTC
We keep the version of the operator in annotations of our deployed components. The maximum length of an annotation is 63 characters.

I'm tackling the issue in https://github.com/kubevirt/cluster-network-addons-operator/pull/286. I will update this BZ once the fix is available D/S.

Comment 2 Lukas Bednar 2020-02-06 08:54:22 UTC
It is still failing now with different message:

```
    Message:               NetworkAddonsConfig is degraded: could not apply (/v1, Kind=ConfigMap) openshift-cnv/cluster-networks-addons-operator-applied-cluster: could not create (/v1, Kind=ConfigMap) openshift-cnv/cluster-networks-addons-operator-applied-cluster: ConfigMap "cluster-networks-addons-operator-applied-cluster" is invalid: metadata.labels: Invalid value: "sha256:701979688f899f531c899fec66beb4bc311d94b2b08c2cdd23b95a86": a valid label must be an empty string or consist of alphanumeric characters, '-', '_' or '.', and must start and end with an alphanumeric character (e.g. 'MyValue',  or 'my_value',  or '12345', regex used for validation is '(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])?')
```

I believe it means that `:` char is not allowed in annotation ??

Comment 3 Petr Horáček 2020-02-06 12:53:48 UTC
While https://github.com/kubevirt/cluster-network-addons-operator/pull/288 is being processed U/S, we temporarily rolled back from using digest to plain version tags again. That should unblock QE from testing. Once is the mentioned PR merged and available D/S, we will move back to digest and verify this bug being fixed.

Lukáš, would you please check whether you are indeed unblocked now? Not sure what to do with this bug in the meanwhile.

Comment 4 Lukas Bednar 2020-02-10 09:41:25 UTC
Yeah, that work around works for us.

Comment 5 Simone Tiraboschi 2020-02-10 12:46:23 UTC
We reverted back to digest for 2.3.0

Comment 6 Meni Yakove 2020-02-27 14:38:10 UTC
cluster-network-addons-operator-84b95447dc-hswzh      1/1       Running   0          5h8m

Comment 9 errata-xmlrpc 2020-05-04 19:10:37 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHEA-2020:2011