Bug 1796828

Summary: When out of memory killer kills a child, gnome-terminal also dies
Product: [Fedora] Fedora Reporter: James Legg <jlegg+rbz>
Component: gnome-terminalAssignee: Debarshi Ray <debarshir>
Status: CLOSED EOL QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 31CC: caillon+fedoraproject, debarshir, egmont, giallu, gnome-sig, john.j5live, mclasen, rhughes, rstrode, sandmann
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-11-24 15:43:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description James Legg 2020-01-31 11:07:50 UTC
Description of problem:
When the kernel's out of memory killer kills a process launched via gnome-terminal, all gnome-terminal windows close.

Version-Release number of selected component (if applicable):
3.34.2-1.fc31

How reproducible:
100%

Steps to Reproduce:
1. Put the following in a file called test.c:
#include <assert.h>
#include <stdlib.h>

int main()
{
	while (1)
	{
		char * buffer = malloc(4096);
		assert(buffer);
		buffer[0] = 'a';
	}
}

2. Compile test.c:
$ gcc test.c

3. If swap is enabled, it's probably best to turn it off before the next step:
$ sudo swapoff -a

4. Run the compiled test program:
$ ./a.out

5. Wait for the out-of-memory killer

Actual results:
All gnome-terminal windows close, taking out any processes running in other windows and tabs, and loosing any previous command output. After the normal oom messages in the journal, there are some lines about gnome-terminal-server.service from systemd:
A process of this unit has been killed by the OOM killer.
Failed with result 'oom-kill'.
Consumed 24.272s CPU time.

Expected results:
Only the process the oom killer killed exits. The word "Killed" is displayed followed by the shell's prompt.

Additional info:
This is a regression from Fedora 30: this bug does not reproduce in gnome-terminal-3.32.2-2.fc30. I also can't reproduce it with konsole5-19.12.1-1.fc31.

Comment 1 Egmont Koblinger 2020-01-31 19:59:14 UTC
I think the solution would be the one outlined at https://gitlab.gnome.org/GNOME/gnome-terminal/issues/206.

Note: I can't reproduce on Ubuntu Eoan with gnome-terminal git master, and I can't think of any relevant change between gnome-terminal 3.32 and 3.34. So it must be some core change between F30 and F31 that now triggers the issue, not something in gnome-terminal per se.

Comment 2 Ben Cotton 2020-11-03 16:16:54 UTC
This message is a reminder that Fedora 31 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 31 on 2020-11-24.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '31'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 31 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 3 Ben Cotton 2020-11-24 15:43:56 UTC
Fedora 31 changed to end-of-life (EOL) status on 2020-11-24. Fedora 31 is
no longer maintained, which means that it will not receive any further
security or bug fix updates. As a result we are closing this bug.

If you can reproduce this bug against a currently maintained version of
Fedora please feel free to reopen this bug against that version. If you
are unable to reopen this bug, please file a new report against the
current release. If you experience problems, please add a comment to this
bug.

Thank you for reporting this bug and we are sorry it could not be fixed.