Bug 179709

Summary:	Review Request: dap-hdf4_handler - HDF4 data handler for the OPeNDAP Data server
Product:	[Fedora] Fedora	Reporter:	Patrice Dumas <pertusus>
Component:	Package Review	Assignee:	Ed Hill <ed>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Package Reviews List <fedora-package-review>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2006-02-26 02:03:37 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	163779, 179707

Description Patrice Dumas 2006-02-02 10:03:02 UTC

SRPM Name or Url: http://www.environnement.ens.fr/perso/dumas/fc-srpms/hdf4_handler-3.5.0-1.src.rpm
Description: 

This is the hdf4 data handler for our data server. It reads HDF4 and HDF-EOS
files and returns DAP responses that are compatible with DAP2 and the
dap-server 3.5 software.

Comment 1 Patrice Dumas 2006-02-02 10:08:32 UTC

This bug depends on #179707, but circular dependencies are not allowed.

Comment 2 Ed Hill 2006-02-20 03:25:30 UTC

Hi Patrice, heres a review:

good:
 + license is acceptable for FE and included 
 + source matches upstream
 + spec file is clean and has no obviuous errors
 + builds in mock on FC4
 + dir ownership and permissions look good
 + very simple package

needswork:
 - please re-name it to "dap-hdf4_handler" or similar
 - license is LGPL not GPL

Comment 3 Patrice Dumas 2006-02-20 10:10:48 UTC

new srpm here:
http://www.environnement.ens.fr/perso/dumas/fc-srpms/dap-hdf4_handler-3.5.0-1.src.rpm

Comment 4 Ed Hill 2006-02-20 13:53:30 UTC

Both items from comment #2 are fixed so its APPROVED.

Comment 5 Patrice Dumas 2006-02-26 02:03:37 UTC

Ed, thanks for all the reviews, and sorry for the dap-server mess... Everything
builds in FC3 and FC4, and I reported upstream the issues (including the
HTML::Parser issue) and they're working on it.

Comment 6 Christian Iseli 2006-10-18 13:15:28 UTC

Normalize summary field for easy parsing