Bug 1797368

Summary:	Review Request: perl-String-Interpolate-Named - Interpolate named variables in text strings
Product:	[Fedora] Fedora	Reporter:	Johan Vromans <jvromans>
Component:	Package Review	Assignee:	Petr Pisar <ppisar>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, ppisar
Target Milestone:	---	Flags:	ppisar: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-String-Interpolate-Named-1.00-1.fc33	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-08 00:51:16 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1797362

Description Johan Vromans 2020-02-02 21:46:49 UTC

Spec URL: https://www.chordpro.org/fedora/perl-String-Interpolate-Named.spec
SRPM URL: https://www.chordpro.org/fedora/perl-String-Interpolate-Named-1.00-1.fc29.src.rpm

Description:

This perl module variable substitution in text strings, with the ability to select substitution alternatives based on the actual contents of the variables.

See https://metacpan.org/pod/String::Interpolate::Named .

This package is required by chordpro, see https://bugzilla.redhat.com/show_bug.cgi?id=1797362.

Fedora Account System Username: sciurius

Comment 1 Johan Vromans 2020-02-25 13:55:17 UTC

Spec URL: https://www.chordpro.org/fedora/perl-String-Interpolate-Named.spec
SRPM URL: https://www.chordpro.org/fedora/perl-String-Interpolate-Named-1.00-2.fc31.src.rpm

Comment 2 Johan Vromans 2020-02-27 10:51:12 UTC

Spec URL: https://www.chordpro.org/fedora/perl-String-Interpolate-Named.spec
SRPM URL: https://www.chordpro.org/fedora/perl-String-Interpolate-Named-1.00-3.fc31.src.rpm

Comment 3 Petr Pisar 2020-02-28 09:58:55 UTC

Source and Url addresses are usable. Ok.
Source archive (SHA-256: 727299fa69258b604770e059ec4da906bfde71861fdd1e3e89e30677371c5a80) is original. Ok.
Summary verified from README. Ok.
Description verified from README. Ok.
License verified from lib/String/Interpolate/Named.pm and README. Ok.
No XS code, noarch BuildArch is Ok.

FIX: Build-require 'perl(Exporter)' (lib/String/Interpolate/Named.pm:10).

All tests pass. Ok.

$ rpmlint perl-String-Interpolate-Named.spec ../SRPMS/perl-String-Interpolate-Named-1.00-3.fc33.src.rpm ../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm 
sh: /usr/bin/python2: No such file or directory
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.

$ rpm -q -lv -p ../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm 
drwxr-xr-x    2 root     root                        0 Feb 28 10:50 /usr/share/doc/perl-String-Interpolate-Named
-rw-r--r--    1 root     root                      780 Oct 31 13:33 /usr/share/doc/perl-String-Interpolate-Named/Changes
-rw-r--r--    1 root     root                     1154 Oct 31 13:53 /usr/share/doc/perl-String-Interpolate-Named/README
-rw-r--r--    1 root     root                     3573 Feb 28 10:50 /usr/share/man/man3/String::Interpolate::Named.3pm.gz
drwxr-xr-x    2 root     root                        0 Feb 28 10:50 /usr/share/perl5/vendor_perl/String
drwxr-xr-x    2 root     root                        0 Feb 28 10:50 /usr/share/perl5/vendor_perl/String/Interpolate
-rw-r--r--    1 root     root                     8687 Oct 31 13:56 /usr/share/perl5/vendor_perl/String/Interpolate/Named.pm
File layout and the permissions are Ok.

$ rpm -q --requires -p ../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(:MODULE_COMPAT_5.30.1)
      1 perl(:VERSION) >= 5.10.1
      1 perl(Carp)
      1 perl(Exporter)
      1 perl(parent)
      1 perl(strict)
      1 perl(utf8)
      1 perl(warnings)
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsZstd) <= 5.4.18-1
Binary requires are Ok.

$ rpm -q --provides -p ../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm | sort -f | uniq -c
      1 perl(String::Interpolate::Named) = 1.00
      1 perl-String-Interpolate-Named = 1.00-3.fc33
Binary provides are Ok.

$ resolvedeps rawhide ../RPMS/noarch/perl-String-Interpolate-Named-1.00-3.fc33.noarch.rpm 
Binary dependencies are resolvable. Ok.

The package builds in F33 (https://koji.fedoraproject.org/koji/taskinfo?taskID=41981404). Ok.

Otherwise the package is in line with Fedora and Perl packaging guide lines.

Please correct the 'FIX' item before building this package.
Resolution: Package APPROVED.

Comment 4 Gwyn Ciesla 2020-02-28 15:01:41 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-String-Interpolate-Named

Comment 5 Fedora Update System 2020-03-02 06:51:20 UTC

FEDORA-2020-a557087bf4 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a557087bf4

Comment 6 Fedora Update System 2020-03-02 06:51:32 UTC

FEDORA-2020-750276af0e has been submitted as an update to Fedora 31. https://bodhi.fedoraproject.org/updates/FEDORA-2020-750276af0e

Comment 7 Fedora Update System 2020-03-08 00:51:16 UTC

perl-String-Interpolate-Named-1.00-1.fc31 has been pushed to the Fedora 31 stable repository. If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2020-03-16 20:17:26 UTC

perl-String-Interpolate-Named-1.00-1.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2020-03-16 20:30:01 UTC

perl-String-Interpolate-Named-1.00-1.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.