Bug 1797496

Summary:	Add RHCOS os to osinfo - for compatability API between 4.3 to 4.4
Product:	Red Hat Enterprise Virtualization Manager	Reporter:	Roy Golan <rgolan>
Component:	ovirt-engine	Assignee:	Liran Rotenberg <lrotenbe>
Status:	CLOSED ERRATA	QA Contact:	Nisim Simsolo <nsimsolo>
Severity:	unspecified	Docs Contact:
Priority:	high
Version:	4.3.7	CC:	lrotenbe, michal.skrivanek, nsimsolo, pelauter, rbarry, rdlugyhe, Rhev-m-bugs
Target Milestone:	ovirt-4.3.9	Keywords:	ZStream
Target Release:	4.3.9
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.9.1	Doc Type:	Enhancement
Doc Text:	The current release adds support for Red Hat CoreOS (RHCOS), a single-purpose container operating system. This support enables you to create virtual machines that run RHCOS. These virtual machines are also backward compatible with RHV 4.3 clusters.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-04-02 16:32:17 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Virt	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1726907
Bug Blocks:

Description Roy Golan 2020-02-03 09:56:54 UTC

Description of problem:

The RHCOS support is bit different between 4.3 to 4.4.

4.3 - create a VM with a valid ignition file in initialization.custom_script
4.3 - create a VM with vm.os.type=rhcos_x86_64

To make it compatible between versions we need to add RHCOS OS to 4.3 and change usages to add os.type=rhcos_x86_64 i.e openshift/installer[1] and ovirt-terraform-provider [2]

[1] https://github.com/openshift/installer/blob/master/data/data/ovirt/masters/main.tf
[2] 



Version-Release number of selected component (if applicable):
4.7.2 - when RHCOS support was added

How reproducible:
100%

Steps to Reproduce:
1. Have an RHCOS VM with ignition in custom_script
2. Start VM 

Actual results:
RHCOS uses ignition in 4.3 but not in 4.4

Expected results:
To start ignition on both


Additional info:

both openshift/install and terraform-provider-ovirt are missing support for os property and issues will be opened against them as well.

Comment 2 Roy Golan 2020-02-05 11:26:17 UTC

We have a problem with the api now - how to run vm + and init, back compat way.

on 4.3  - vmService.start().useCloudInit(true).send()

on 4.4  - vmService.start().useIgnition(true).send()

I'm expecting vmService.start().Initialize(true) and let the engine pick the right type based on os.

Comment 3 Ryan Barry 2020-02-05 12:19:02 UTC

Sure, but no need to clear keywords or milestones just yet ;)

It's not a bug which FailedQA with no time to fix it.

Comment 7 Nisim Simsolo 2020-03-09 14:56:30 UTC

Verification builds:
ovirt-engine-4.3.9.2-0.3.el7
vdsm-4.30.42-1.el7ev.x86_64
libvirt-daemon-4.5.0-23.el7_7.5.x86_64
qemu-kvm-rhev-2.12.0-33.el7_7.10.x86_64
rhcos-44.81.202002241126-0-openstack.x86_64

Verification scenario:
1. Create new VM, Set OS type to RHCOS, attach rhcos qcow image to VM. 
2. From edit VM dialog -> initial run, check "use cloud-init/sysprep" checkbox, change VM hostname and add ignition script in custom script textbox.
3. Run VM.
4. Verify hostname change and ignition script configuration is applied on the VM.

Comment 11 errata-xmlrpc 2020-04-02 16:32:17 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:1308