Bug 1797559

Summary:	RFE: Provide "machineconfiguration.openshift.io/role" as code constant to other operator authors
Product:	OpenShift Container Platform	Reporter:	Šimon Lukašík <slukasik>
Component:	Machine Config Operator	Assignee:	Antonio Murdaca <amurdaca>
Status:	CLOSED ERRATA	QA Contact:	Michael Nguyen <mnguyen>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	4.4	CC:	amurdaca, jerzhang, smilner
Target Milestone:	---
Target Release:	4.5.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-07-13 17:13:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Šimon Lukašík 2020-02-03 12:20:19 UTC

Description of problem:

Other operators may need to use the MCO and hence they need to know this onstant. Keeping this constant on a single place may turn out to be advantageous to the whole OpenShift ecosystem.

https://github.com/openshift/machine-config-operator/pull/1418

Thank You!

Comment 8 Michael Nguyen 2020-04-07 18:37:53 UTC

Verified on 4.5.0-0.nightly-2020-04-06-083820.  Commit for MCO in build contains the commit for the RFE.

$ oc get clusterversion
NAME      VERSION                             AVAILABLE   PROGRESSING   SINCE   STATUS
version   4.5.0-0.nightly-2020-04-06-083820   True        False         52m     Cluster version is 4.5.0-0.nightly-2020-04-06-083820


$ oc image info -a ../all-the-pull-secrets.json $(oc adm release -a ../all-the-pull-secrets.json info --image-for=machine-config-operator registry.svc.ci.openshift.org/ocp/release:4.5.0-0.nightly-2020-04-06-083820) | grep SOURCE_GIT_COMMIT
             SOURCE_GIT_COMMIT=a195251a12c0e8f9d9994c2662d3eb31c0a50eb1

$ git checkout a195251a12c0e8f9d9994c2662d3eb31c0a50eb1
Note: switching to 'a195251a12c0e8f9d9994c2662d3eb31c0a50eb1'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at a195251a Merge pull request #1614 from dcbw/ignore-new-ovn-ports
$ git branch --contains 88f8833034b4595444afba29100b7689addc453a
* (HEAD detached at a195251a)
  master
  release-4.5

Comment 10 errata-xmlrpc 2020-07-13 17:13:54 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409