Bug 1797691

Summary: conda fails to build with Python 3.9: frozendict imports abc from collections
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-frozendictAssignee: Igor Raits <igor.raits>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: cstratak, igor.raits, mhroncok, orion, tir.karthi, zbyszek
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-02-04 13:29:07 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1785415    

Description Miro Hrončok 2020-02-03 16:35:15 UTC
conda fails to build with Python 3.9.0a3.

+ py.test-3.9 -vv -m 'not integration' --deselect=tests/core/test_solve.py::test_python2_update --deselect=tests/core/test_subdir_data.py::test_subdir_data_prefers_conda_to_tar_bz2 --deselect=tests/core/test_package_cache_data.py::test_ProgressiveFetchExtract_prefers_conda_v2_format --deselect=tests/core/test_subdir_data.py::test_use_only_tar_bz2 --ignore tests/core/test_initialize.py
ImportError while loading conftest '/builddir/build/BUILD/conda-4.8.2/conftest.py'.
conftest.py:10: in <module>
    from conda.gateways.disk.create import TemporaryDirectory
conda/gateways/disk/create.py:18: in <module>
    from .delete import path_is_clean, rm_rf
conda/gateways/disk/delete.py:19: in <module>
    from ...base.context import context
conda/base/context.py:25: in <module>
    from frozendict import frozendict
/usr/lib/python3.9/site-packages/frozendict/__init__.py:16: in <module>
    class frozendict(collections.Mapping):
E   AttributeError: module 'collections' has no attribute 'Mapping'

See https://docs.python.org/3.9/whatsnew/3.9.html#removed

"The abstract base classes in collections.abc no longer are exposed in the regular collections module. This will help create a clearer distinction between the concrete classes and the abstract base classes."



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.9/fedora-rawhide-x86_64/01219465-conda/

For all our attempts to build conda with Python 3.9, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/package/conda/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.9:
https://copr.fedorainfracloud.org/coprs/g/python/python3.9/

Let us know here if you have any questions.

Python 3.9 will be included in Fedora 33. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.9.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Orion Poplawski 2020-02-04 01:15:39 UTC
It seems to me that this is a problem with frozendict, not conda.

Comment 2 Karthikeyan Singaravelan 2020-02-04 12:28:28 UTC
frozendict PR : https://github.com/slezica/python-frozendict/pull/30

Comment 3 Zbigniew Jędrzejewski-Szmek 2020-02-04 12:51:50 UTC
Thanks for the pointer. I pushed the patch to python-frozendict dist-git. This should be enough to get
the new version in the python39 copr if I'm not mistaken.

Comment 4 Miro Hrončok 2020-02-04 12:57:21 UTC
Orion, also consider contacting conda upstream about this, frozendict seems no longer maintained upstream and this will bite when installing stuff via pip (i.e. not from RPM).

There should be a native implementation of immutable mapping in 3.9, but the PEP is not approved yet:  https://www.python.org/dev/peps/pep-0603/

Comment 5 Zbigniew Jędrzejewski-Szmek 2020-02-04 13:17:53 UTC
After frozendict there was another issue in conda itself. I pushed a commit to dist-git now.