Bug 1797708
| Summary: | writecache: High watermark must be greater than or equal to low watermark | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Corey Marthaler <cmarthal> |
| Component: | lvm2 | Assignee: | LVM and device-mapper development team <lvm-team> |
| lvm2 sub component: | Cache Logical Volumes | QA Contact: | cluster-qe <cluster-qe> |
| Status: | CLOSED ERRATA | Docs Contact: | |
| Severity: | low | ||
| Priority: | unspecified | CC: | agk, heinzm, jbrassow, mcsontos, msnitzer, pasik, prajnoha, teigland, zkabelac |
| Version: | 8.2 | Flags: | pm-rhel:
mirror+
|
| Target Milestone: | rc | ||
| Target Release: | 8.0 | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | lvm2-2.03.08-2.el8 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-04-28 16:59:23 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Corey Marthaler
2020-02-03 17:17:49 UTC
Fixed for cases like above where the user sets both high and low to an invalid combination: https://sourceware.org/git/?p=lvm2.git;a=commit;h=adbb0a8d5bd0f735a756e32effcf0bddac0f6de7 lvconvert --type writecache --cachevol fast --cachesettings "high_watermark=5 low_watermark=6" foo/main High watermark must be greater than or equal to low watermark. Invalid writecache settings. We can't catch cases where one value is set and it is invalid in combination with the kernel's default value for the other. In those cases the kernel error message will suffice. The message should just be "must be greater than low watermark." that or the check needs to change. # Lower than [root@hayes-02 ~]# lvconvert --yes --type writecache --cachesettings 'low_watermark=56 high_watermark=3' --cachevol writecache_sanity/rename_pool_A writecache_sanity/rename_orig_A High watermark must be greater than or equal to low watermark. Invalid writecache settings. # Equal to [root@hayes-02 ~]# lvconvert --yes --type writecache --cachesettings 'low_watermark=56 high_watermark=56' --cachevol writecache_sanity/rename_pool_A writecache_sanity/rename_orig_A High watermark must be greater than or equal to low watermark. Invalid writecache settings. in master: https://sourceware.org/git/?p=lvm2.git;a=commitdiff;h=2284f845b0328df97dfef6200905b3b462cd3cce - log_error("High watermark must be greater than or equal to low watermark."); + log_error("High watermark must be greater than low watermark."); Fix verified in the latest rpms. kernel-4.18.0-179.el8 BUILT: Fri Feb 14 17:03:01 CST 2020 lvm2-2.03.08-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 lvm2-libs-2.03.08-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 device-mapper-1.02.169-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 device-mapper-libs-1.02.169-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 device-mapper-event-1.02.169-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 device-mapper-event-libs-1.02.169-2.el8 BUILT: Mon Feb 24 11:21:38 CST 2020 [root@hayes-02 ~]# lvs -a -o +devices LV VG Attr LSize Pool Origin Data% Meta% Move Log Cpy%Sync Convert Devices cworigin writecache_sanity -wi------- 4.00g /dev/sdd1(0) test_writecache writecache_sanity -wi------- 2.00g /dev/sdh1(0) [root@hayes-02 ~]# lvconvert --yes --type writecache --cachesettings 'low_watermark=56 high_watermark=3' --cachevol writecache_sanity/test_writecache writecache_sanity/cworigin High watermark must be greater than low watermark. Invalid writecache settings. [root@hayes-02 ~]# lvconvert --yes --type writecache --cachesettings 'low_watermark=56 high_watermark=56' --cachevol writecache_sanity/test_writecache writecache_sanity/cworigin High watermark must be greater than low watermark. Invalid writecache settings. [root@hayes-02 ~]# lvconvert --yes --type writecache --cachesettings 'low_watermark=56 high_watermark=57' --cachevol writecache_sanity/test_writecache writecache_sanity/cworigin Logical volume writecache_sanity/cworigin now has write cache. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHEA-2020:1881 |