Bug 1797854

Summary:	octave-symbolic: FTBFS in Fedora rawhide
Product:	[Fedora] Fedora	Reporter:	Orion Poplawski <orion>
Component:	octave-symbolic	Assignee:	Thomas Sailer <fedora>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	32	CC:	cbm, fedora, releng
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
URL:	https://koschei.fedoraproject.org/package/octave-symbolic
Whiteboard:
Fixed In Version:	octave-symbolic-2.9.0-1.fc32	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2020-03-16 20:36:12 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1750908

Description Orion Poplawski 2020-02-04 03:31:39 UTC

Description of problem:
Package octave-symbolic fails to build from source in Fedora rawhide.

Version-Release number of selected component (if applicable):
2.8.0-4.fc32

Steps to Reproduce:
koji build --scratch f32 octave-symbolic-2.8.0-4.fc32.src.rpm

Additional info:
This package is tracked by Koschei. See:
https://koschei.fedoraproject.org/package/octave-symbolic

>>>>> processing /builddir/build/BUILDROOT/octave-symbolic-2.8.0-4.fc32.noarch/usr/share/octave/packages/symbolic-2.8.0/finiteset.m
***** test
 e = finiteset();
 s = finiteset(sym(1));
 s2 = e + s;
 assert (isequal (s, s2))
!!!!! test failed
Python exception: TypeError: unsupported operand type(s) for +: 'Singleton' and 'FiniteSet'
    occurred at line 8 of the Python code block:
    return x + y

This appears to have happened with the sympy 1.5 update.

Comment 1 Orion Poplawski 2020-02-04 03:35:13 UTC

Filed upstream: https://savannah.gnu.org/bugs/index.php?57737

Comment 2 Orion Poplawski 2020-02-08 19:36:10 UTC

*** Bug 1799823 has been marked as a duplicate of this bug. ***

Comment 3 Ben Cotton 2020-02-11 16:36:07 UTC

This bug appears to have been reported against 'rawhide' during the Fedora 32 development cycle.
Changing version to 32.

Comment 4 Fedora Release Engineering 2020-02-16 04:31:57 UTC

Dear Maintainer,

your package has not been built successfully in 32. Action is required from you.

If you can fix your package to build, perform a build in koji, and either create
an update in bodhi, or close this bug without creating an update, if updating is
not appropriate [1]. If you are working on a fix, set the status to ASSIGNED to
acknowledge this. Following the latest policy for such packages [2], your package
will be orphaned if this bug remains in NEW state more than 8 weeks.

A week before the mass branching of Fedora 33 according to the schedule [3],
any packages not successfully rebuilt at least on Fedora 31 will be
retired regardless of the status of this bug.

[1] https://fedoraproject.org/wiki/Updates_Policy
[2] https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/
[3] https://fedoraproject.org/wiki/Releases/33/Schedule

Comment 5 Orion Poplawski 2020-02-19 04:35:11 UTC

We are waiting for an upstream release that should resolve these issues.

Comment 6 Colin Macdonald 2020-03-04 22:05:03 UTC

Orion, if you can spare a moment to review upstream https://sourceforge.net/p/octave/package-releases/408/ we can get this out.

After its official, I will patch the spec something like below, notably dropping the patch and the sed line.

- - - -

diff --git a/octave-symbolic.spec b/octave-symbolic.spec
index ee2f2f2..0dd47d2 100644
--- a/octave-symbolic.spec
+++ b/octave-symbolic.spec
@@ -4,14 +4,12 @@
 %global _python_bytecompile_extra 0
 
 Name:           octave-%{octpkg}
-Version:        2.8.0
-Release:        5%{?dist}
+Version:        2.9.0
+Release:        1%{?dist}
 Summary:        Symbolic computations for Octave
 License:        GPLv3+
 URL:            https://octave.sourceforge.io/%{octpkg}
 Source0:        https://downloads.sourceforge.net/octave/%{octpkg}-%{version}.tar.gz
-# in next upstream version
-Patch0:         solve-skip-some-nondeterministic-doctests.patch
 
 BuildArch:      noarch
 BuildRequires:  octave-devel
@@ -33,8 +31,6 @@ variable precision arithmetic and other features.
 
 %prep
 %setup -q -n %{octpkg}-%{version}
-sed -i "s/python = 'python'/python = 'python3'/" inst/private/defaultpython.m
-%patch0 -p1
 
 %build
 %octave_pkg_build
@@ -79,6 +75,9 @@ popd
 
 
 %changelog
+* Wed Mar 04 2020 Colin B. Macdonald <cbm.org> - 2.9.0-1
+- Update to 2.9.0 (bugz#1797854)
+
 * Wed Jan 29 2020 Fedora Release Engineering <releng> - 2.8.0-5
 - Rebuilt for https://fedoraproject.org/wiki/Fedora_32_Mass_Rebuild
 
- - - -

Comment 7 Fedora Update System 2020-03-08 22:34:10 UTC

FEDORA-2020-587e973600 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-587e973600

Comment 8 Fedora Update System 2020-03-09 14:54:34 UTC

octave-symbolic-2.9.0-1.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-587e973600

Comment 9 Fedora Update System 2020-03-16 20:36:12 UTC

octave-symbolic-2.9.0-1.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.